mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: lkml@pengaru.com, linux-kernel <linux-kernel@vger.kernel.org>,
	vcaputo@pengaru.com,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	intel-wired-lan@lists.osuosl.org, khalidm <khalidm@cisco.com>,
	David Singleton <davsingl@cisco.com>,
	Aaron Brown <aaron.f.brown@intel.com>,
	Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: Re: [BUG] 4.11.0-rc1 panic on shutdown X61s
Date: Sun, 12 Mar 2017 23:23:33 +0100	[thread overview]
Message-ID: <20170312222333.hm54nl2ul5iuixap@pd.tnic> (raw)
In-Reply-To: <CAHp75Ve7SWivf=TTuq-qA=iM20E==OmSZD2YAmt0LVJQg47Osg@mail.gmail.com>

On Sun, Mar 12, 2017 at 03:55:08PM +0200, Andy Shevchenko wrote:
> On Sun, Mar 12, 2017 at 2:26 PM, Borislav Petkov <bp@alien8.de> wrote:
> > On Sun, Mar 12, 2017 at 12:57:03PM +0100, Borislav Petkov wrote:
> >> On Sat, Mar 11, 2017 at 09:37:23PM -0800, lkml@pengaru.com wrote:
> >> > Hello list,
> >> >
> >> > Here's a photo of the panic, on imgur to be kind to vger:
> >> > http://imgur.com/a/wZI32
> >> >
> >> > I'm out on a sailboat so can't really do much, but had a chance with internet
> >>
> >> So you didn't bring another box with you on the sailboat to connect it to the
> >> laptop over netconsole to catch full dmesg, did you?
> >
> > Hahah, you're so in luck: I just sent this mail and hibernated my laptop
> > and got the same BUG. What's the chance of that happening?! Apparently
> > big enough.
> >
> > But I was able to catch the warning before it too. So the question is,
> > do you have an e1000e eth controller in that machine too?
> >
> > Because the symptoms below are consistent with the observed behavior:
> > e1000e fails to initialize MSI interrupts for whatever reason and falls
> > back to legacy interrupts.
> >
> > Then, PCI core shuts down and BUGs because the msi_list is empty.
> >
> > Anyway, lemme add e1000e people too to the fun thread.
> >
> 
> The only change that IMHO matters happened between v4.10 and v4.11-rc1 is this:
> 
> @@ -6276,8 +6274,8 @@ static int e1000e_pm_freeze(struct device *dev)
>                 /* Quiesce the device without resetting the hardware */
>                 e1000e_down(adapter, false);
>                 e1000_free_irq(adapter);
> +               e1000e_reset_interrupt_capability(adapter);
>         }
> -       e1000e_reset_interrupt_capability(adapter);
> 
> So, it apparently misses something for the other case, like
> pci_disable_msi() call or so.

Well, lemme add the people from

  7e54d9d063fa ("e1000e: driver trying to free already-free irq")

to CC then. :-)

Thanks.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

  reply	other threads:[~2017-03-12 22:23 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-12  5:37 lkml
2017-03-12 11:57 ` Borislav Petkov
2017-03-12 12:26   ` Borislav Petkov
2017-03-12 13:55     ` Andy Shevchenko
2017-03-12 22:23       ` Borislav Petkov [this message]
2017-03-13 16:46         ` Bjørn Mork
2017-03-14  1:20           ` Brown, Aaron F
2017-03-14  1:43             ` Borislav Petkov
2017-03-14  2:40             ` lkml
2017-03-16 20:13               ` [Intel-wired-lan] " Bowers, AndrewX
2017-03-22  2:04                 ` lkml
2017-03-22  2:13                   ` lkml
2017-03-22 19:00                     ` Borislav Petkov
2017-03-24  6:18                       ` Jeff Kirsher
2017-03-24  8:47                         ` Borislav Petkov
2017-03-14  7:49             ` Neftin, Sasha
2017-03-14  8:28             ` Bjørn Mork
2017-03-14  8:40               ` Bjørn Mork
2017-03-12 18:24     ` lkml

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170312222333.hm54nl2ul5iuixap@pd.tnic \
    --to=bp@alien8.de \
    --cc=aaron.f.brown@intel.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=davsingl@cisco.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=khalidm@cisco.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lkml@pengaru.com \
    --cc=vcaputo@pengaru.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®