From: "Bjørn Mork" <bjorn@mork.no>
To: Borislav Petkov <bp@alien8.de>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
lkml@pengaru.com, linux-kernel <linux-kernel@vger.kernel.org>,
vcaputo@pengaru.com,
"linux-pci\@vger.kernel.org" <linux-pci@vger.kernel.org>,
intel-wired-lan@lists.osuosl.org, khalidm <khalidm@cisco.com>,
David Singleton <davsingl@cisco.com>,
Aaron Brown <aaron.f.brown@intel.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: Re: [BUG] 4.11.0-rc1 panic on shutdown X61s
Date: Mon, 13 Mar 2017 17:46:06 +0100 [thread overview]
Message-ID: <87shmhjfap.fsf@miraculix.mork.no> (raw)
In-Reply-To: <20170312222333.hm54nl2ul5iuixap@pd.tnic> (Borislav Petkov's message of "Sun, 12 Mar 2017 23:23:33 +0100")
Borislav Petkov <bp@alien8.de> writes:
> On Sun, Mar 12, 2017 at 03:55:08PM +0200, Andy Shevchenko wrote:
>
>> The only change that IMHO matters happened between v4.10 and v4.11-rc1 is this:
>>
>> @@ -6276,8 +6274,8 @@ static int e1000e_pm_freeze(struct device *dev)
>> /* Quiesce the device without resetting the hardware */
>> e1000e_down(adapter, false);
>> e1000_free_irq(adapter);
>> + e1000e_reset_interrupt_capability(adapter);
>> }
>> - e1000e_reset_interrupt_capability(adapter);
>>
>> So, it apparently misses something for the other case, like
>> pci_disable_msi() call or so.
>
> Well, lemme add the people from
>
> 7e54d9d063fa ("e1000e: driver trying to free already-free irq")
>
> to CC then. :-)
Already did that a week ago:
https://www.spinics.net/lists/netdev/msg423379.html
Haven't heard anything back yet. Wondering if they are waiting for
someone else to submit the pretty obvious revert? Don't understand why
that should take more than a minute to figure out. It's not like they
are testing these changes anyway...
Bjørn
next prev parent reply other threads:[~2017-03-13 16:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-12 5:37 lkml
2017-03-12 11:57 ` Borislav Petkov
2017-03-12 12:26 ` Borislav Petkov
2017-03-12 13:55 ` Andy Shevchenko
2017-03-12 22:23 ` Borislav Petkov
2017-03-13 16:46 ` Bjørn Mork [this message]
2017-03-14 1:20 ` Brown, Aaron F
2017-03-14 1:43 ` Borislav Petkov
2017-03-14 2:40 ` lkml
2017-03-16 20:13 ` [Intel-wired-lan] " Bowers, AndrewX
2017-03-22 2:04 ` lkml
2017-03-22 2:13 ` lkml
2017-03-22 19:00 ` Borislav Petkov
2017-03-24 6:18 ` Jeff Kirsher
2017-03-24 8:47 ` Borislav Petkov
2017-03-14 7:49 ` Neftin, Sasha
2017-03-14 8:28 ` Bjørn Mork
2017-03-14 8:40 ` Bjørn Mork
2017-03-12 18:24 ` lkml
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87shmhjfap.fsf@miraculix.mork.no \
--to=bjorn@mork.no \
--cc=aaron.f.brown@intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=bp@alien8.de \
--cc=davsingl@cisco.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=khalidm@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lkml@pengaru.com \
--cc=vcaputo@pengaru.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome