From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: Jiri Kosina <jikos@kernel.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hid: cp2112: select GPIOLIB_IRQCHIP instead of depending on it
Date: Mon, 13 Mar 2017 10:48:19 +0100 [thread overview]
Message-ID: <20170313094819.GD4378@mail.corp.redhat.com> (raw)
In-Reply-To: <1489344968-12813-1-git-send-email-bgolaszewski@baylibre.com>
On Mar 12 2017 or thereabouts, Bartosz Golaszewski wrote:
> GPIOLIB_IRQCHIP is not visible to user, so we can't depend on it.
>
> Depend on GPIOLIB but select GPIOLIB_IRQCHIP.
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> ---
Makes sense. Good catch
Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> drivers/hid/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index 1aeb80e..00e2809 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -214,7 +214,8 @@ config HID_CMEDIA
>
> config HID_CP2112
> tristate "Silicon Labs CP2112 HID USB-to-SMBus Bridge support"
> - depends on USB_HID && I2C && GPIOLIB && GPIOLIB_IRQCHIP
> + depends on USB_HID && I2C && GPIOLIB
> + select GPIOLIB_IRQCHIP
> ---help---
> Support for Silicon Labs CP2112 HID USB to SMBus Master Bridge.
> This is a HID device driver which registers as an i2c adapter
> --
> 2.9.3
>
next prev parent reply other threads:[~2017-03-13 9:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-12 18:56 Bartosz Golaszewski
2017-03-13 9:48 ` Benjamin Tissoires [this message]
2017-03-21 14:30 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170313094819.GD4378@mail.corp.redhat.com \
--to=benjamin.tissoires@redhat.com \
--cc=bgolaszewski@baylibre.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome