* [PATCH] hid: cp2112: select GPIOLIB_IRQCHIP instead of depending on it
@ 2017-03-12 18:56 Bartosz Golaszewski
2017-03-13 9:48 ` Benjamin Tissoires
2017-03-21 14:30 ` Jiri Kosina
0 siblings, 2 replies; 3+ messages in thread
From: Bartosz Golaszewski @ 2017-03-12 18:56 UTC (permalink / raw)
To: Jiri Kosina, Benjamin Tissoires
Cc: linux-input, linux-kernel, Bartosz Golaszewski
GPIOLIB_IRQCHIP is not visible to user, so we can't depend on it.
Depend on GPIOLIB but select GPIOLIB_IRQCHIP.
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
drivers/hid/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index 1aeb80e..00e2809 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -214,7 +214,8 @@ config HID_CMEDIA
config HID_CP2112
tristate "Silicon Labs CP2112 HID USB-to-SMBus Bridge support"
- depends on USB_HID && I2C && GPIOLIB && GPIOLIB_IRQCHIP
+ depends on USB_HID && I2C && GPIOLIB
+ select GPIOLIB_IRQCHIP
---help---
Support for Silicon Labs CP2112 HID USB to SMBus Master Bridge.
This is a HID device driver which registers as an i2c adapter
--
2.9.3
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hid: cp2112: select GPIOLIB_IRQCHIP instead of depending on it
2017-03-12 18:56 [PATCH] hid: cp2112: select GPIOLIB_IRQCHIP instead of depending on it Bartosz Golaszewski
@ 2017-03-13 9:48 ` Benjamin Tissoires
2017-03-21 14:30 ` Jiri Kosina
1 sibling, 0 replies; 3+ messages in thread
From: Benjamin Tissoires @ 2017-03-13 9:48 UTC (permalink / raw)
To: Bartosz Golaszewski; +Cc: Jiri Kosina, linux-input, linux-kernel
On Mar 12 2017 or thereabouts, Bartosz Golaszewski wrote:
> GPIOLIB_IRQCHIP is not visible to user, so we can't depend on it.
>
> Depend on GPIOLIB but select GPIOLIB_IRQCHIP.
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> ---
Makes sense. Good catch
Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> drivers/hid/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index 1aeb80e..00e2809 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -214,7 +214,8 @@ config HID_CMEDIA
>
> config HID_CP2112
> tristate "Silicon Labs CP2112 HID USB-to-SMBus Bridge support"
> - depends on USB_HID && I2C && GPIOLIB && GPIOLIB_IRQCHIP
> + depends on USB_HID && I2C && GPIOLIB
> + select GPIOLIB_IRQCHIP
> ---help---
> Support for Silicon Labs CP2112 HID USB to SMBus Master Bridge.
> This is a HID device driver which registers as an i2c adapter
> --
> 2.9.3
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hid: cp2112: select GPIOLIB_IRQCHIP instead of depending on it
2017-03-12 18:56 [PATCH] hid: cp2112: select GPIOLIB_IRQCHIP instead of depending on it Bartosz Golaszewski
2017-03-13 9:48 ` Benjamin Tissoires
@ 2017-03-21 14:30 ` Jiri Kosina
1 sibling, 0 replies; 3+ messages in thread
From: Jiri Kosina @ 2017-03-21 14:30 UTC (permalink / raw)
To: Bartosz Golaszewski; +Cc: Benjamin Tissoires, linux-input, linux-kernel
On Sun, 12 Mar 2017, Bartosz Golaszewski wrote:
> GPIOLIB_IRQCHIP is not visible to user, so we can't depend on it.
>
> Depend on GPIOLIB but select GPIOLIB_IRQCHIP.
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> ---
> drivers/hid/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index 1aeb80e..00e2809 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -214,7 +214,8 @@ config HID_CMEDIA
>
> config HID_CP2112
> tristate "Silicon Labs CP2112 HID USB-to-SMBus Bridge support"
> - depends on USB_HID && I2C && GPIOLIB && GPIOLIB_IRQCHIP
> + depends on USB_HID && I2C && GPIOLIB
> + select GPIOLIB_IRQCHIP
> ---help---
> Support for Silicon Labs CP2112 HID USB to SMBus Master Bridge.
> This is a HID device driver which registers as an i2c adapter
Applied, thanks.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-21 14:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-12 18:56 [PATCH] hid: cp2112: select GPIOLIB_IRQCHIP instead of depending on it Bartosz Golaszewski
2017-03-13 9:48 ` Benjamin Tissoires
2017-03-21 14:30 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome