mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mikko Rapeli <mikko.rapeli@iki.fi>
To: Hauke Mehrtens <hauke@hauke-m.de>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, jarod@redhat.com, jogo@openwrt.org,
	david.heidelberger@ixit.cz, maillist-linux@barfooze.de
Subject: Re: [PATCH 1/4] uapi glibc compat: add libc compat code when not build for kernel
Date: Mon, 13 Mar 2017 13:28:04 +0200	[thread overview]
Message-ID: <20170313112804.GZ8672@lakka.kapsi.fi> (raw)
In-Reply-To: <20170312220039.16885-2-hauke@hauke-m.de>

On Sun, Mar 12, 2017 at 11:00:36PM +0100, Hauke Mehrtens wrote:
> Instead of checking if this header file is used in the glibc, check if
> iti is not used in kernel context, this way it will also work with
> other libc implementations like musl.
> 
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>

Accked-by: Mikko Rapeli <mikko.rapeli@iki.fi>

> ---
>  include/uapi/linux/libc-compat.h | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/include/uapi/linux/libc-compat.h b/include/uapi/linux/libc-compat.h
> index 44b8a6bd5fe1..7c1fead03c50 100644
> --- a/include/uapi/linux/libc-compat.h
> +++ b/include/uapi/linux/libc-compat.h
> @@ -48,8 +48,8 @@
>  #ifndef _UAPI_LIBC_COMPAT_H
>  #define _UAPI_LIBC_COMPAT_H
>  
> -/* We have included glibc headers... */
> -#if defined(__GLIBC__)
> +/* We have included libc headers... */
> +#if !defined(__KERNEL__)
>  
>  /* Coordinate with glibc net/if.h header. */
>  #if defined(_NET_IF_H) && defined(__USE_MISC)
> @@ -168,7 +168,7 @@
>  /* If we did not see any headers from any supported C libraries,
>   * or we are being included in the kernel, then define everything
>   * that we need. */
> -#else /* !defined(__GLIBC__) */
> +#else /* defined(__KERNEL__) */
>  
>  /* Definitions for if.h */
>  #define __UAPI_DEF_IF_IFCONF 1
> @@ -208,6 +208,6 @@
>  /* Definitions for xattr.h */
>  #define __UAPI_DEF_XATTR		1
>  
> -#endif /* __GLIBC__ */
> +#endif /* __KERNEL__ */
>  
>  #endif /* _UAPI_LIBC_COMPAT_H */
> -- 
> 2.11.0
> 

  reply	other threads:[~2017-03-13 11:28 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-12 22:00 [PATCH 0/4] uapi glibc compat: fix musl libc compatibility Hauke Mehrtens
2017-03-12 22:00 ` [PATCH 1/4] uapi glibc compat: add libc compat code when not build for kernel Hauke Mehrtens
2017-03-13 11:28   ` Mikko Rapeli [this message]
2017-03-12 22:00 ` [PATCH 2/4] uapi glibc compat: fix build if libc defines IFF_ECHO Hauke Mehrtens
2017-03-13 11:28   ` Mikko Rapeli
2017-03-12 22:00 ` [PATCH 3/4] uapi glibc compat: Do not check for __USE_MISC Hauke Mehrtens
2017-03-13 11:29   ` Mikko Rapeli
2017-03-16  7:59   ` David Woodhouse
2017-03-16  8:26     ` Mikko Rapeli
2017-03-17 18:17       ` Hauke Mehrtens
2017-03-12 22:00 ` [PATCH 4/4] uapi/if_ether.h: prevent redefinition of struct ethhdr Hauke Mehrtens
2017-03-13 11:31   ` Mikko Rapeli
2017-03-28 12:01 ` [PATCH 0/4] uapi glibc compat: fix musl libc compatibility Hauke Mehrtens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170313112804.GZ8672@lakka.kapsi.fi \
    --to=mikko.rapeli@iki.fi \
    --cc=davem@davemloft.net \
    --cc=david.heidelberger@ixit.cz \
    --cc=hauke@hauke-m.de \
    --cc=jarod@redhat.com \
    --cc=jogo@openwrt.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maillist-linux@barfooze.de \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®