From: Lee Jones <lee.jones@linaro.org>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mfd: retu: Add OF device ID table
Date: Tue, 14 Mar 2017 10:04:15 +0000 [thread overview]
Message-ID: <20170314100415.mwjm76lkskmtkpv3@dell> (raw)
In-Reply-To: <096d8b8a-7429-a61e-dbc0-b74309d131e0@osg.samsung.com>
On Fri, 10 Mar 2017, Javier Martinez Canillas wrote:
> Hello Lee,
>
> On 02/21/2017 10:34 AM, Javier Martinez Canillas wrote:
> > The driver doesn't have a struct of_device_id table but supported devices
> > are registered via Device Trees. This is working on the assumption that a
> > I2C device registered via OF will always match a legacy I2C device ID and
> > that the MODALIAS reported will always be of the form i2c:<device>.
> >
> > But this could change in the future so the correct approach is to have a
> > OF device ID table if the devices are registered via OF.
> >
> > The compatible strings don't have a vendor prefix because that's how it's
> > used currently, and changing this will be a Device Tree ABI break.
> >
> > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> > ---
>
> Any comment on this patch and 2/2?
Apologies, I've been on vacation.
Will get to it in due course.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2017-03-14 10:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-21 13:34 Javier Martinez Canillas
2017-02-21 13:34 ` [PATCH 2/2] mfd: tps6105x: " Javier Martinez Canillas
2017-03-15 10:35 ` Lee Jones
2017-03-10 13:23 ` [PATCH 1/2] mfd: retu: " Javier Martinez Canillas
2017-03-14 10:04 ` Lee Jones [this message]
2017-03-15 10:34 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170314100415.mwjm76lkskmtkpv3@dell \
--to=lee.jones@linaro.org \
--cc=javier@osg.samsung.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®