[RESEND PATCH] drm: amd: remove broken include path

[RESEND PATCH] drm: amd: remove broken include path

[Arnd Bergmann]

The AMD ACP driver adds "-I../acp -I../acp/include" to the gcc command
line, which makes no sense, since these are evaluated relative to the
build directory. When we build with "make W=1", they instead cause
a warning:

cc1: error: ../acp/: No such file or directory [-Werror=missing-include-dirs]
cc1: error: ../acp/include: No such file or directory [-Werror=missing-include-dirs]
cc1: all warnings being treated as errors
../scripts/Makefile.build:289: recipe for target 'drivers/gpu/drm/amd/amdgpu/amdgpu_drv.o' failed
../scripts/Makefile.build:289: recipe for target 'drivers/gpu/drm/amd/amdgpu/amdgpu_device.o' failed
../scripts/Makefile.build:289: recipe for target 'drivers/gpu/drm/amd/amdgpu/amdgpu_kms.o' failed

This removes the subdir-ccflags variable that evidently did not
serve any purpose here.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
Originally submitted in June 2016. All other patches for this warning got
merged, once this gets in we can turn on the warning flag for everyone.
---
 drivers/gpu/drm/amd/acp/Makefile | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/acp/Makefile b/drivers/gpu/drm/amd/acp/Makefile
index 8363cb57915b..8a08e81ee90d 100644
--- a/drivers/gpu/drm/amd/acp/Makefile
+++ b/drivers/gpu/drm/amd/acp/Makefile
@@ -3,6 +3,4 @@
 # of AMDSOC/AMDGPU drm driver.
 # It provides the HW control for ACP related functionalities.
 
-subdir-ccflags-y += -I$(AMDACPPATH)/ -I$(AMDACPPATH)/include
-
 AMD_ACP_FILES := $(AMDACPPATH)/acp_hw.o
-- 
2.9.0

Re: [RESEND PATCH] drm: amd: remove broken include path

[Alex Deucher]

On Tue, Mar 14, 2017 at 5:27 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> The AMD ACP driver adds "-I../acp -I../acp/include" to the gcc command
> line, which makes no sense, since these are evaluated relative to the
> build directory. When we build with "make W=1", they instead cause
> a warning:
>
> cc1: error: ../acp/: No such file or directory [-Werror=missing-include-dirs]
> cc1: error: ../acp/include: No such file or directory [-Werror=missing-include-dirs]
> cc1: all warnings being treated as errors
> ../scripts/Makefile.build:289: recipe for target 'drivers/gpu/drm/amd/amdgpu/amdgpu_drv.o' failed
> ../scripts/Makefile.build:289: recipe for target 'drivers/gpu/drm/amd/amdgpu/amdgpu_device.o' failed
> ../scripts/Makefile.build:289: recipe for target 'drivers/gpu/drm/amd/amdgpu/amdgpu_kms.o' failed
>
> This removes the subdir-ccflags variable that evidently did not
> serve any purpose here.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied.  thanks!

Alex

> ---
> Originally submitted in June 2016. All other patches for this warning got
> merged, once this gets in we can turn on the warning flag for everyone.
> ---
>  drivers/gpu/drm/amd/acp/Makefile | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/acp/Makefile b/drivers/gpu/drm/amd/acp/Makefile
> index 8363cb57915b..8a08e81ee90d 100644
> --- a/drivers/gpu/drm/amd/acp/Makefile
> +++ b/drivers/gpu/drm/amd/acp/Makefile
> @@ -3,6 +3,4 @@
>  # of AMDSOC/AMDGPU drm driver.
>  # It provides the HW control for ACP related functionalities.
>
> -subdir-ccflags-y += -I$(AMDACPPATH)/ -I$(AMDACPPATH)/include
> -
>  AMD_ACP_FILES := $(AMDACPPATH)/acp_hw.o
> --
> 2.9.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel