* [PATCH] scsi: storvsc: remove return at end of void function
@ 2017-03-16 6:59 Miguel Bernal Marin
2017-04-13 23:28 ` KY Srinivasan
0 siblings, 1 reply; 2+ messages in thread
From: Miguel Bernal Marin @ 2017-03-16 6:59 UTC (permalink / raw)
To: K. Y. Srinivasan, Martin K. Petersen
Cc: linux-kernel, linux-scsi, devel, Haiyang Zhang,
Stephen Hemminger, James E.J. Bottomley
storvsc_on_channel_callback is a void function and the return
statement at the end is not useful.
Found with checkpatch.
Signed-off-by: Miguel Bernal Marin <miguel.bernal.marin@linux.intel.com>
---
drivers/scsi/storvsc_drv.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
index 3d70d1cf49a3..538f3e131275 100644
--- a/drivers/scsi/storvsc_drv.c
+++ b/drivers/scsi/storvsc_drv.c
@@ -1191,8 +1191,6 @@ static void storvsc_on_channel_callback(void *context)
break;
}
} while (1);
-
- return;
}
static int storvsc_connect_to_vsp(struct hv_device *device, u32 ring_size,
--
2.12.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* RE: [PATCH] scsi: storvsc: remove return at end of void function
2017-03-16 6:59 [PATCH] scsi: storvsc: remove return at end of void function Miguel Bernal Marin
@ 2017-04-13 23:28 ` KY Srinivasan
0 siblings, 0 replies; 2+ messages in thread
From: KY Srinivasan @ 2017-04-13 23:28 UTC (permalink / raw)
To: Miguel Bernal Marin, Martin K. Petersen
Cc: linux-kernel, linux-scsi, devel, Haiyang Zhang,
Stephen Hemminger, James E.J. Bottomley
> -----Original Message-----
> From: Miguel Bernal Marin [mailto:miguel.bernal.marin@linux.intel.com]
> Sent: Thursday, March 16, 2017 12:00 AM
> To: KY Srinivasan <kys@microsoft.com>; Martin K. Petersen
> <martin.petersen@oracle.com>
> Cc: linux-kernel@vger.kernel.org; linux-scsi@vger.kernel.org;
> devel@linuxdriverproject.org; Haiyang Zhang <haiyangz@microsoft.com>;
> Stephen Hemminger <sthemmin@microsoft.com>; James E.J. Bottomley
> <jejb@linux.vnet.ibm.com>
> Subject: [PATCH] scsi: storvsc: remove return at end of void function
>
> storvsc_on_channel_callback is a void function and the return
> statement at the end is not useful.
>
> Found with checkpatch.
>
> Signed-off-by: Miguel Bernal Marin <miguel.bernal.marin@linux.intel.com>
Reviewed-by: K. Y. Srinivasan <kys@microsoft.com>
> ---
> drivers/scsi/storvsc_drv.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
> index 3d70d1cf49a3..538f3e131275 100644
> --- a/drivers/scsi/storvsc_drv.c
> +++ b/drivers/scsi/storvsc_drv.c
> @@ -1191,8 +1191,6 @@ static void storvsc_on_channel_callback(void
> *context)
> break;
> }
> } while (1);
> -
> - return;
> }
>
> static int storvsc_connect_to_vsp(struct hv_device *device, u32 ring_size,
> --
> 2.12.0
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-13 23:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-16 6:59 [PATCH] scsi: storvsc: remove return at end of void function Miguel Bernal Marin
2017-04-13 23:28 ` KY Srinivasan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®