From: Javier Martinez Canillas <javier@osg.samsung.com>
To: linux-kernel@vger.kernel.org
Cc: Arnd Bergmann <arnd@arndb.de>,
Javier Martinez Canillas <javier@osg.samsung.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: [PATCH v2 2/3] misc: ds1682: Add OF device ID table
Date: Tue, 21 Mar 2017 10:50:48 -0300 [thread overview]
Message-ID: <20170321135049.16211-2-javier@osg.samsung.com> (raw)
In-Reply-To: <20170321135049.16211-1-javier@osg.samsung.com>
The driver doesn't have a struct of_device_id table but supported devices
are registered via Device Trees. This is working on the assumption that a
I2C device registered via OF will always match a legacy I2C device ID and
that the MODALIAS reported will always be of the form i2c:<device>.
But this could change in the future so the correct approach is to have an
OF device ID table if the devices are registered via OF.
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
Changes in v2:
- Avoid using of_match_ptr() macro which leads to build warnings when
CONFIG_OF is not enabled (Arnd Bergmann).
drivers/misc/ds1682.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/misc/ds1682.c b/drivers/misc/ds1682.c
index c7112276a039..28bb495f0cf1 100644
--- a/drivers/misc/ds1682.c
+++ b/drivers/misc/ds1682.c
@@ -227,9 +227,16 @@ static const struct i2c_device_id ds1682_id[] = {
};
MODULE_DEVICE_TABLE(i2c, ds1682_id);
+static const struct of_device_id ds1682_of_match[] = {
+ { .compatible = "dallas,ds1682", },
+ {}
+};
+MODULE_DEVICE_TABLE(of, ds1682_of_match);
+
static struct i2c_driver ds1682_driver = {
.driver = {
.name = "ds1682",
+ .of_match_table = ds1682_of_match,
},
.probe = ds1682_probe,
.remove = ds1682_remove,
--
2.9.3
next prev parent reply other threads:[~2017-03-21 13:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-21 13:50 [PATCH v2 1/3] misc: tsl2550: " Javier Martinez Canillas
2017-03-21 13:50 ` Javier Martinez Canillas [this message]
2017-03-21 13:54 ` [PATCH v2 2/3] misc: ds1682: " Arnd Bergmann
2017-03-21 13:50 ` [PATCH v2 3/3] eeprom: idt_89hpesx: " Javier Martinez Canillas
2017-03-21 13:54 ` Arnd Bergmann
2017-03-21 14:52 ` Serge Semin
2017-03-21 13:54 ` [PATCH v2 1/3] misc: tsl2550: " Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170321135049.16211-2-javier@osg.samsung.com \
--to=javier@osg.samsung.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®