mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Matthew Giassa <matthew@giassa.net>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: forest@alittletooquiet.net, devel@driverdev.osuosl.org,
	gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] staging: vt6656: rf.c: spaces preferred around that '-'
Date: Tue, 21 Mar 2017 07:17:58 -0700	[thread overview]
Message-ID: <20170321141758.2tkatnqyphdpw7rm@darkstar> (raw)
In-Reply-To: <20170321125551.GC32449@mwanda>

* Dan Carpenter <dan.carpenter@oracle.com> [2017-03-21 15:55:52 +0300]:

>On Mon, Mar 20, 2017 at 08:46:01PM -0700, Matthew Giassa wrote:
>> Resolving 2 checkpatch warnings generated due to:
>> CHECK: spaces preferred around that '-'
>>
>> Signed-off-by: Matthew Giassa <matthew@giassa.net>
>> ---
>>  drivers/staging/vt6656/rf.c | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/staging/vt6656/rf.c b/drivers/staging/vt6656/rf.c
>> index 0e3a62a..fe09627 100644
>> --- a/drivers/staging/vt6656/rf.c
>> +++ b/drivers/staging/vt6656/rf.c
>> @@ -611,7 +611,7 @@ int vnt_rf_write_embedded(struct vnt_private *priv, u32 data)
>>  	reg_data[3] = (u8)(data >> 24);
>>
>>  	vnt_control_out(priv, MESSAGE_TYPE_WRITE_IFRF,
>> -				0, 0, ARRAY_SIZE(reg_data), reg_data);
>> +			0, 0, ARRAY_SIZE(reg_data), reg_data);
>
>This isn't described in the changelog.
>
>regards,
>dan carpenter
>

Would it be preferable if the changelog was more verbose? The
literal text from the checkpatch.pl warning itself is indeed in the
changelog:

>On Mon, Mar 20, 2017 at 08:46:01PM -0700, Matthew Giassa wrote:
>> Resolving 2 checkpatch warnings generated due to:
>> CHECK: spaces preferred around that '-'

Cheers.

      reply	other threads:[~2017-03-21 14:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-21  3:45 [PATCH] staging: vt6656: rf.c: resolve all checkpatch issues Matthew Giassa
2017-03-21  3:46 ` [PATCH 1/2] staging: vt6656: rf.c: alignment should match open parentheses Matthew Giassa
2017-03-21  3:46 ` [PATCH 2/2] staging: vt6656: rf.c: spaces preferred around that '-' Matthew Giassa
2017-03-21 12:55   ` Dan Carpenter
2017-03-21 14:17     ` Matthew Giassa [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170321141758.2tkatnqyphdpw7rm@darkstar \
    --to=matthew@giassa.net \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=forest@alittletooquiet.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®