* [PATCH 1/1] mmc: core: export emmc revision via sysfs @ 2017-03-21 22:01 ` Jin Qian 2017-03-21 22:17 ` Jaehoon Chung 0 siblings, 1 reply; 3+ messages in thread From: Jin Qian @ 2017-03-21 22:01 UTC (permalink / raw) To: Ulf Hansson, Shawn Lin, Adrian Hunter, Jaehoon Chung, Linus Walleij, Uri Yanai, Dong Aisheng, Chaotian Jing, Pratibhasagar V, Gwendal Grignou, linux-mmc, linux-kernel Cc: Jin Qian, Jin Qian Extend sysfs to access ext_csd revision information. Signed-off-by: Jin Qian <jinqian@google.com> Signed-off-by: Jin Qian <jinqian@android.com> --- drivers/mmc/core/mmc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c index 7fd722868875..08c62c9bec48 100644 --- a/drivers/mmc/core/mmc.c +++ b/drivers/mmc/core/mmc.c @@ -779,6 +779,7 @@ MMC_DEV_ATTR(manfid, "0x%06x\n", card->cid.manfid); MMC_DEV_ATTR(name, "%s\n", card->cid.prod_name); MMC_DEV_ATTR(oemid, "0x%04x\n", card->cid.oemid); MMC_DEV_ATTR(prv, "0x%x\n", card->cid.prv); +MMC_DEV_ATTR(rev, "0x%x\n", card->ext_csd.rev); MMC_DEV_ATTR(pre_eol_info, "%02x\n", card->ext_csd.pre_eol_info); MMC_DEV_ATTR(life_time, "0x%02x 0x%02x\n", card->ext_csd.device_life_time_est_typ_a, @@ -836,6 +837,7 @@ static struct attribute *mmc_std_attrs[] = { &dev_attr_name.attr, &dev_attr_oemid.attr, &dev_attr_prv.attr, + &dev_attr_rev.attr, &dev_attr_pre_eol_info.attr, &dev_attr_life_time.attr, &dev_attr_serial.attr, -- 2.12.1.500.gab5fba24ee-goog ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] mmc: core: export emmc revision via sysfs 2017-03-21 22:01 ` [PATCH 1/1] mmc: core: export emmc revision via sysfs Jin Qian @ 2017-03-21 22:17 ` Jaehoon Chung 2017-03-23 0:23 ` Jin Qian 0 siblings, 1 reply; 3+ messages in thread From: Jaehoon Chung @ 2017-03-21 22:17 UTC (permalink / raw) To: Jin Qian, Ulf Hansson, Shawn Lin, Adrian Hunter, Linus Walleij, Uri Yanai, Dong Aisheng, Chaotian Jing, Pratibhasagar V, Gwendal Grignou, linux-mmc, linux-kernel Hi, On 03/22/2017 07:01 AM, Jin Qian wrote: > Extend sysfs to access ext_csd revision information. > > Signed-off-by: Jin Qian <jinqian@google.com> > Signed-off-by: Jin Qian <jinqian@android.com> I think you can choose one of them for signed-off tag. > --- > drivers/mmc/core/mmc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c > index 7fd722868875..08c62c9bec48 100644 > --- a/drivers/mmc/core/mmc.c > +++ b/drivers/mmc/core/mmc.c > @@ -779,6 +779,7 @@ MMC_DEV_ATTR(manfid, "0x%06x\n", card->cid.manfid); > MMC_DEV_ATTR(name, "%s\n", card->cid.prod_name); > MMC_DEV_ATTR(oemid, "0x%04x\n", card->cid.oemid); > MMC_DEV_ATTR(prv, "0x%x\n", card->cid.prv); > +MMC_DEV_ATTR(rev, "0x%x\n", card->ext_csd.rev); I'm not sure but if someone want to know ext_csd revision information, attribute name might be more clearly. e,g) ext_csd_rev? It's my preference. :) Best Regards, Jaehoon Chung > MMC_DEV_ATTR(pre_eol_info, "%02x\n", card->ext_csd.pre_eol_info); > MMC_DEV_ATTR(life_time, "0x%02x 0x%02x\n", > card->ext_csd.device_life_time_est_typ_a, > @@ -836,6 +837,7 @@ static struct attribute *mmc_std_attrs[] = { > &dev_attr_name.attr, > &dev_attr_oemid.attr, > &dev_attr_prv.attr, > + &dev_attr_rev.attr, > &dev_attr_pre_eol_info.attr, > &dev_attr_life_time.attr, > &dev_attr_serial.attr, > ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] mmc: core: export emmc revision via sysfs 2017-03-21 22:17 ` Jaehoon Chung @ 2017-03-23 0:23 ` Jin Qian 0 siblings, 0 replies; 3+ messages in thread From: Jin Qian @ 2017-03-23 0:23 UTC (permalink / raw) To: Jaehoon Chung Cc: Ulf Hansson, Shawn Lin, Adrian Hunter, Linus Walleij, Uri Yanai, Dong Aisheng, Chaotian Jing, Pratibhasagar V, Gwendal Grignou, linux-mmc, linux-kernel Removed redundant signoff. export rev to collect some statistics on how many devices are running with which mmc revision. Other attr name seems follow cid.<name> or ext_csd.<name>. Thanks, jin On Tue, Mar 21, 2017 at 3:17 PM, Jaehoon Chung <jh80.chung@samsung.com> wrote: > Hi, > > On 03/22/2017 07:01 AM, Jin Qian wrote: >> Extend sysfs to access ext_csd revision information. >> >> Signed-off-by: Jin Qian <jinqian@google.com> >> Signed-off-by: Jin Qian <jinqian@android.com> > > I think you can choose one of them for signed-off tag. > >> --- >> drivers/mmc/core/mmc.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c >> index 7fd722868875..08c62c9bec48 100644 >> --- a/drivers/mmc/core/mmc.c >> +++ b/drivers/mmc/core/mmc.c >> @@ -779,6 +779,7 @@ MMC_DEV_ATTR(manfid, "0x%06x\n", card->cid.manfid); >> MMC_DEV_ATTR(name, "%s\n", card->cid.prod_name); >> MMC_DEV_ATTR(oemid, "0x%04x\n", card->cid.oemid); >> MMC_DEV_ATTR(prv, "0x%x\n", card->cid.prv); >> +MMC_DEV_ATTR(rev, "0x%x\n", card->ext_csd.rev); > > I'm not sure but if someone want to know ext_csd revision information, attribute name might be more clearly. > e,g) ext_csd_rev? > > It's my preference. :) > > Best Regards, > Jaehoon Chung > >> MMC_DEV_ATTR(pre_eol_info, "%02x\n", card->ext_csd.pre_eol_info); >> MMC_DEV_ATTR(life_time, "0x%02x 0x%02x\n", >> card->ext_csd.device_life_time_est_typ_a, >> @@ -836,6 +837,7 @@ static struct attribute *mmc_std_attrs[] = { >> &dev_attr_name.attr, >> &dev_attr_oemid.attr, >> &dev_attr_prv.attr, >> + &dev_attr_rev.attr, >> &dev_attr_pre_eol_info.attr, >> &dev_attr_life_time.attr, >> &dev_attr_serial.attr, >> > ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-23 0:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20170321220337epcas2p2439e1bf9ecbf4140f23fe7e2bdfcd831@epcas2p2.samsung.com>
2017-03-21 22:01 ` [PATCH 1/1] mmc: core: export emmc revision via sysfs Jin Qian
2017-03-21 22:17 ` Jaehoon Chung
2017-03-23 0:23 ` Jin Qian
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®