* [PATCH] hwmon: asus_atk0110.c fix uninitialized data access
@ 2017-03-23 15:03 Arnd Bergmann
2017-03-23 15:32 ` Luca Tettamanti
2017-03-23 20:26 ` Guenter Roeck
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2017-03-23 15:03 UTC (permalink / raw)
To: Luca Tettamanti, Jean Delvare, Guenter Roeck
Cc: Arnd Bergmann, linux-hwmon, linux-kernel
The latest gcc-7 snapshot adds a warning to point out that when
atk_read_value_old or atk_read_value_new fails, we copy
uninitialized data into sensor->cached_value:
drivers/hwmon/asus_atk0110.c: In function 'atk_input_show':
drivers/hwmon/asus_atk0110.c:651:26: error: 'value' may be used uninitialized in this function [-Werror=maybe-uninitialized]
Adding an error check avoids this. All versions of the driver
are affected.
Fixes: 2c03d07ad54d ("hwmon: Add Asus ATK0110 support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/hwmon/asus_atk0110.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/hwmon/asus_atk0110.c b/drivers/hwmon/asus_atk0110.c
index cccef87963e0..975c43d446f8 100644
--- a/drivers/hwmon/asus_atk0110.c
+++ b/drivers/hwmon/asus_atk0110.c
@@ -646,6 +646,9 @@ static int atk_read_value(struct atk_sensor_data *sensor, u64 *value)
else
err = atk_read_value_new(sensor, value);
+ if (err)
+ return err;
+
sensor->is_valid = true;
sensor->last_updated = jiffies;
sensor->cached_value = *value;
--
2.9.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] hwmon: asus_atk0110.c fix uninitialized data access
2017-03-23 15:03 [PATCH] hwmon: asus_atk0110.c fix uninitialized data access Arnd Bergmann
@ 2017-03-23 15:32 ` Luca Tettamanti
2017-03-23 20:26 ` Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: Luca Tettamanti @ 2017-03-23 15:32 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: Jean Delvare, Guenter Roeck, linux-hwmon, LKML
On 23 March 2017 at 16:03, Arnd Bergmann <arnd@arndb.de> wrote:
> The latest gcc-7 snapshot adds a warning to point out that when
> atk_read_value_old or atk_read_value_new fails, we copy
> uninitialized data into sensor->cached_value:
>
> drivers/hwmon/asus_atk0110.c: In function 'atk_input_show':
> drivers/hwmon/asus_atk0110.c:651:26: error: 'value' may be used uninitialized in this function [-Werror=maybe-uninitialized]
Ops, thanks for catching this.
>
> Adding an error check avoids this. All versions of the driver
> are affected.
>
> Fixes: 2c03d07ad54d ("hwmon: Add Asus ATK0110 support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Luca Tettamanti <kronos.it@gmail.com>
> ---
> drivers/hwmon/asus_atk0110.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/hwmon/asus_atk0110.c b/drivers/hwmon/asus_atk0110.c
> index cccef87963e0..975c43d446f8 100644
> --- a/drivers/hwmon/asus_atk0110.c
> +++ b/drivers/hwmon/asus_atk0110.c
> @@ -646,6 +646,9 @@ static int atk_read_value(struct atk_sensor_data *sensor, u64 *value)
> else
> err = atk_read_value_new(sensor, value);
>
> + if (err)
> + return err;
> +
> sensor->is_valid = true;
> sensor->last_updated = jiffies;
> sensor->cached_value = *value;
> --
> 2.9.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] hwmon: asus_atk0110.c fix uninitialized data access
2017-03-23 15:03 [PATCH] hwmon: asus_atk0110.c fix uninitialized data access Arnd Bergmann
2017-03-23 15:32 ` Luca Tettamanti
@ 2017-03-23 20:26 ` Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2017-03-23 20:26 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: Luca Tettamanti, Jean Delvare, linux-hwmon, linux-kernel
On Thu, Mar 23, 2017 at 04:03:11PM +0100, Arnd Bergmann wrote:
> The latest gcc-7 snapshot adds a warning to point out that when
> atk_read_value_old or atk_read_value_new fails, we copy
> uninitialized data into sensor->cached_value:
>
> drivers/hwmon/asus_atk0110.c: In function 'atk_input_show':
> drivers/hwmon/asus_atk0110.c:651:26: error: 'value' may be used uninitialized in this function [-Werror=maybe-uninitialized]
>
> Adding an error check avoids this. All versions of the driver
> are affected.
>
Nice catch!
Applied, thanks.
Guenter
> Fixes: 2c03d07ad54d ("hwmon: Add Asus ATK0110 support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/hwmon/asus_atk0110.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/hwmon/asus_atk0110.c b/drivers/hwmon/asus_atk0110.c
> index cccef87963e0..975c43d446f8 100644
> --- a/drivers/hwmon/asus_atk0110.c
> +++ b/drivers/hwmon/asus_atk0110.c
> @@ -646,6 +646,9 @@ static int atk_read_value(struct atk_sensor_data *sensor, u64 *value)
> else
> err = atk_read_value_new(sensor, value);
>
> + if (err)
> + return err;
> +
> sensor->is_valid = true;
> sensor->last_updated = jiffies;
> sensor->cached_value = *value;
> --
> 2.9.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-23 20:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-23 15:03 [PATCH] hwmon: asus_atk0110.c fix uninitialized data access Arnd Bergmann
2017-03-23 15:32 ` Luca Tettamanti
2017-03-23 20:26 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®