From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Claudiu Beznea <claudiu.beznea@microchip.com>,
thierry.reding@gmail.com, robh+dt@kernel.org, pawel.moll@arm.com,
mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
galak@codeaurora.org, linux-pwm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
nicolas.ferre@microchip.com, cristian.birsan@microchip.com,
andrei.pistirica@microchip.com, tudor.ambarus@microchip.com,
eugen.hristev@microchip.com
Subject: Re: [PATCH v3 1/2] drivers: pwm: pwm-atmel: switch to atomic PWM
Date: Mon, 27 Mar 2017 15:15:30 +0200 [thread overview]
Message-ID: <20170327131530.ifexyrgrp5egtbtr@piout.net> (raw)
In-Reply-To: <20170327150237.69d8523f@bbrezillon>
On 27/03/2017 at 15:02:37 +0200, Boris Brezillon wrote:
> Hi Claudiu,
>
> On Wed, 22 Mar 2017 15:29:34 +0200
> Claudiu Beznea <claudiu.beznea@microchip.com> wrote:
>
> > static const struct platform_device_id atmel_pwm_devtypes[] = {
> > {
> > .name = "at91sam9rl-pwm",
> > - .driver_data = (kernel_ulong_t)&atmel_pwm_data_v1,
> > + .driver_data = (kernel_ulong_t)&atmel_pwm_regs_v1,
> > }, {
> > .name = "sama5d3-pwm",
> > - .driver_data = (kernel_ulong_t)&atmel_pwm_data_v2,
> > + .driver_data = (kernel_ulong_t)&atmel_pwm_regs_v2,
> > }, {
> > /* sentinel */
> > },
>
> Unrelated to this series, but can you prepare a patch to get rid of
> this platform id table (AT91 platforms have completely switched to DT
> for quite some time now).
>
Please, don't until AVR32 is gone.
> You can also get rid of the "if (pdev->dev.of_node)" condition in
> atmel_pwm_probe() since it's guaranteed to be true, otherwise the
> ->probe() method wouldn't be called.
>
> Thanks,
>
> Boris
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-03-27 13:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-22 13:29 [PATCH v3 0/2] " Claudiu Beznea
2017-03-22 13:29 ` [PATCH v3 1/2] drivers: pwm: pwm-atmel: " Claudiu Beznea
2017-03-27 12:57 ` Boris Brezillon
2017-03-27 13:02 ` Boris Brezillon
2017-03-27 13:15 ` Alexandre Belloni [this message]
2017-03-27 14:05 ` m18063
2017-03-22 13:29 ` [PATCH v3 2/2] drivers: pwm: pwm-atmel: enable PWM on sama5d2 Claudiu Beznea
2017-03-27 13:03 ` Boris Brezillon
2017-04-06 14:33 ` [PATCH v3 0/2] switch to atomic PWM Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170327131530.ifexyrgrp5egtbtr@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=andrei.pistirica@microchip.com \
--cc=boris.brezillon@free-electrons.com \
--cc=claudiu.beznea@microchip.com \
--cc=cristian.birsan@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=eugen.hristev@microchip.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nicolas.ferre@microchip.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=tudor.ambarus@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®