From: Sebastian Reichel <sre@kernel.org>
To: Tony Lindgren <tony@atomide.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtc: cpcap: fix improper use of IRQ_NONE for request_threaded_irq
Date: Mon, 27 Mar 2017 16:24:43 +0200 [thread overview]
Message-ID: <20170327142443.zkaiieehqeirk4pi@earth> (raw)
In-Reply-To: <20170327033423.4536-1-tony@atomide.com>
[-- Attachment #1: Type: text/plain, Size: 1486 bytes --]
Hi,
On Sun, Mar 26, 2017 at 08:34:23PM -0700, Tony Lindgren wrote:
> There's a funny typo where IRQ_NONE is used instead of IRQF_TRIGGER_NONE
> for request_threaded_irq(). Let's fix it before it gets copied elsewhere.
>
> Fixes: dd3bf50b35e3 ("rtc: cpcap: new rtc driver")
> Cc: Sebastian Reichel <sre@kernel.org>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
Reviewed-By: Sebastian Reichel <sre@kernel.org>
-- Sebastian
> ---
> drivers/rtc/rtc-cpcap.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/rtc/rtc-cpcap.c b/drivers/rtc/rtc-cpcap.c
> --- a/drivers/rtc/rtc-cpcap.c
> +++ b/drivers/rtc/rtc-cpcap.c
> @@ -275,7 +275,7 @@ static int cpcap_rtc_probe(struct platform_device *pdev)
>
> rtc->alarm_irq = platform_get_irq(pdev, 0);
> err = devm_request_threaded_irq(dev, rtc->alarm_irq, NULL,
> - cpcap_rtc_alarm_irq, IRQ_NONE,
> + cpcap_rtc_alarm_irq, IRQF_TRIGGER_NONE,
> "rtc_alarm", rtc);
> if (err) {
> dev_err(dev, "Could not request alarm irq: %d\n", err);
> @@ -291,7 +291,7 @@ static int cpcap_rtc_probe(struct platform_device *pdev)
> */
> rtc->update_irq = platform_get_irq(pdev, 1);
> err = devm_request_threaded_irq(dev, rtc->update_irq, NULL,
> - cpcap_rtc_update_irq, IRQ_NONE,
> + cpcap_rtc_update_irq, IRQF_TRIGGER_NONE,
> "rtc_1hz", rtc);
> if (err) {
> dev_err(dev, "Could not request update irq: %d\n", err);
> --
> 2.12.1
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-03-27 14:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-27 3:34 Tony Lindgren
2017-03-27 14:24 ` Sebastian Reichel [this message]
2017-04-08 14:39 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170327142443.zkaiieehqeirk4pi@earth \
--to=sre@kernel.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®