From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: m18063 <Claudiu.Beznea@microchip.com>
Cc: "nicolas.ferre@atmel.com" <nicolas.ferre@atmel.com>,
"boris.brezillon@free-electrons.com"
<boris.brezillon@free-electrons.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"pawel.moll@arm.com" <pawel.moll@arm.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
"galak@codeaurora.org" <galak@codeaurora.org>,
"ludovic.desroches@atmel.com" <ludovic.desroches@atmel.com>,
"cyrille.pitchen@atmel.com" <cyrille.pitchen@atmel.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ATM: dts: at91: sama5d2_xplained: add pwm controller
Date: Tue, 28 Mar 2017 13:34:52 +0200 [thread overview]
Message-ID: <20170328113452.bje7har2ymbr32ad@piout.net> (raw)
In-Reply-To: <60c37963-509f-7764-9554-520694294909@microchip.com>
Hi,
On 28/03/2017 at 14:04:25 +0300, m18063 wrote:
> >> diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi
> >> index cd459e8..e88785e 100644
> >> --- a/arch/arm/boot/dts/sama5d2.dtsi
> >> +++ b/arch/arm/boot/dts/sama5d2.dtsi
> >> @@ -1098,6 +1098,14 @@
> >> status = "disabled";
> >> };
> >>
> >> + pwm0: pwm@f802c000 {
> >> + compatible = "atmel,sama5d2-pwm";
> > This compatible is not documented and is not used in any driver. Is that
> > really working?
>
> At the moment I send this patch another driver patch was send
> to used this device tree bindings and also to document it.
> Meanwhile you reviewed also that other patch.
>
Yes, I received that patch first, without the other ones. You should
have put everything in the same series.
> Please let me know if you want to send again this DT patch since
> I didn't yet receive any inputs its v2.
>
I'll take it once the pwm patch are taken by Thierry because it is not
useful as-is, unless you use:
compatible = "atmel,sama5d2-pwm", "atmel,sama5d3-pwm";
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
prev parent reply other threads:[~2017-03-28 11:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-23 8:32 Claudiu Beznea
2017-02-23 8:42 ` Alexandre Belloni
2017-02-23 8:43 ` m18063
2017-03-28 11:04 ` m18063
2017-03-28 11:34 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170328113452.bje7har2ymbr32ad@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=Claudiu.Beznea@microchip.com \
--cc=boris.brezillon@free-electrons.com \
--cc=cyrille.pitchen@atmel.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@atmel.com \
--cc=mark.rutland@arm.com \
--cc=nicolas.ferre@atmel.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®