* [PATCH] aspeed-lpc-ctrl: include linux/types.h for uapi header
@ 2017-03-28 14:10 Arnd Bergmann
2017-03-28 14:15 ` Joel Stanley
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2017-03-28 14:10 UTC (permalink / raw)
To: Benjamin Herrenschmidt, Greg Kroah-Hartman, Cyril Bur, Joel Stanley
Cc: Arnd Bergmann, linux-kernel
The newly added header file triggers a sanity check:
usr/include/linux/aspeed-lpc-ctrl.h:44: found __[us]{8,16,32,64} type without #include <linux/types.h>
We should include linux/types.h explicitly to ensure the header
can be included from user space.
Fixes: 6c4e97678501 ("drivers/misc: Add Aspeed LPC control driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
include/uapi/linux/aspeed-lpc-ctrl.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/uapi/linux/aspeed-lpc-ctrl.h b/include/uapi/linux/aspeed-lpc-ctrl.h
index f96fa995a3f0..c328c976c684 100644
--- a/include/uapi/linux/aspeed-lpc-ctrl.h
+++ b/include/uapi/linux/aspeed-lpc-ctrl.h
@@ -11,6 +11,7 @@
#define _UAPI_LINUX_ASPEED_LPC_CTRL_H
#include <linux/ioctl.h>
+#include <linux/types.h>
/* Window types */
#define ASPEED_LPC_CTRL_WINDOW_FLASH 1
--
2.9.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] aspeed-lpc-ctrl: include linux/types.h for uapi header
2017-03-28 14:10 [PATCH] aspeed-lpc-ctrl: include linux/types.h for uapi header Arnd Bergmann
@ 2017-03-28 14:15 ` Joel Stanley
2017-03-28 15:01 ` Arnd Bergmann
0 siblings, 1 reply; 3+ messages in thread
From: Joel Stanley @ 2017-03-28 14:15 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Benjamin Herrenschmidt, Greg Kroah-Hartman, Cyril Bur,
Linux Kernel Mailing List
On Wed, Mar 29, 2017 at 12:40 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> The newly added header file triggers a sanity check:
>
> usr/include/linux/aspeed-lpc-ctrl.h:44: found __[us]{8,16,32,64} type without #include <linux/types.h>
Thanks Arnd.
What tool are you running to do this check?
> We should include linux/types.h explicitly to ensure the header
> can be included from user space.
>
> Fixes: 6c4e97678501 ("drivers/misc: Add Aspeed LPC control driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Joel Stanley <joel@jms.id.au>
Cheers,
Joel
> ---
> include/uapi/linux/aspeed-lpc-ctrl.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/uapi/linux/aspeed-lpc-ctrl.h b/include/uapi/linux/aspeed-lpc-ctrl.h
> index f96fa995a3f0..c328c976c684 100644
> --- a/include/uapi/linux/aspeed-lpc-ctrl.h
> +++ b/include/uapi/linux/aspeed-lpc-ctrl.h
> @@ -11,6 +11,7 @@
> #define _UAPI_LINUX_ASPEED_LPC_CTRL_H
>
> #include <linux/ioctl.h>
> +#include <linux/types.h>
>
> /* Window types */
> #define ASPEED_LPC_CTRL_WINDOW_FLASH 1
> --
> 2.9.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] aspeed-lpc-ctrl: include linux/types.h for uapi header
2017-03-28 14:15 ` Joel Stanley
@ 2017-03-28 15:01 ` Arnd Bergmann
0 siblings, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2017-03-28 15:01 UTC (permalink / raw)
To: Joel Stanley
Cc: Benjamin Herrenschmidt, Greg Kroah-Hartman, Cyril Bur,
Linux Kernel Mailing List
On Tue, Mar 28, 2017 at 4:15 PM, Joel Stanley <joel@jms.id.au> wrote:
> On Wed, Mar 29, 2017 at 12:40 AM, Arnd Bergmann <arnd@arndb.de> wrote:
>> The newly added header file triggers a sanity check:
>>
>> usr/include/linux/aspeed-lpc-ctrl.h:44: found __[us]{8,16,32,64} type without #include <linux/types.h>
>
> Thanks Arnd.
>
> What tool are you running to do this check?
I was running 'make randconfig' builds.
The warning came from scripts/headers_check.pl.
Arnd
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-28 15:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-28 14:10 [PATCH] aspeed-lpc-ctrl: include linux/types.h for uapi header Arnd Bergmann
2017-03-28 14:15 ` Joel Stanley
2017-03-28 15:01 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®