From: Liviu Dudau <liviu.dudau@arm.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "Brian Starkey" <brian.starkey@arm.com>,
"Mali DP Maintainers" <malidp@foss.arm.com>,
"David Airlie" <airlied@linux.ie>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Mihail Atanassov" <mihail.atanassov@arm.com>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"Shailendra Verma" <shailendra.v@samsung.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm: mali-dp: remove unused variable
Date: Tue, 28 Mar 2017 15:55:23 +0100 [thread overview]
Message-ID: <20170328145523.GO6816@e110455-lin.cambridge.arm.com> (raw)
In-Reply-To: <20170328140812.1410346-1-arnd@arndb.de>
On Tue, Mar 28, 2017 at 04:07:58PM +0200, Arnd Bergmann wrote:
> The newly introduced function causes a harmless build warning:
>
> drivers/gpu/drm/arm/malidp_planes.c: In function 'malidp_plane_atomic_print_state':
> drivers/gpu/drm/arm/malidp_planes.c:98:23: error: unused variable 'mp' [-Werror=unused-variable]
>
> The variable serves no purpose here and can be removed.
Ouch, shame on me for not noticing it :(
Thanks for this!
Acked-by: Liviu Dudau <Liviu.Dudau@arm.com>
>
> Fixes: 242f43b69c61 ("drm: mali-dp: add atomic_print_state for planes")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/gpu/drm/arm/malidp_planes.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/arm/malidp_planes.c b/drivers/gpu/drm/arm/malidp_planes.c
> index 5b0bad87f0b5..afd59e0f7918 100644
> --- a/drivers/gpu/drm/arm/malidp_planes.c
> +++ b/drivers/gpu/drm/arm/malidp_planes.c
> @@ -95,7 +95,6 @@ static void malidp_plane_atomic_print_state(struct drm_printer *p,
> const struct drm_plane_state *state)
> {
> struct malidp_plane_state *ms = to_malidp_plane_state(state);
> - struct malidp_plane *mp = to_malidp_plane(state->plane);
>
> drm_printf(p, "\trotmem_size=%u\n", ms->rotmem_size);
> drm_printf(p, "\tformat_id=%u\n", ms->format);
> --
> 2.9.0
>
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
prev parent reply other threads:[~2017-03-28 14:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 14:07 Arnd Bergmann
2017-03-28 14:55 ` Liviu Dudau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170328145523.GO6816@e110455-lin.cambridge.arm.com \
--to=liviu.dudau@arm.com \
--cc=airlied@linux.ie \
--cc=arnd@arndb.de \
--cc=brian.starkey@arm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=joonas.lahtinen@linux.intel.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=malidp@foss.arm.com \
--cc=mihail.atanassov@arm.com \
--cc=shailendra.v@samsung.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®