From: Bjorn Helgaas <helgaas@kernel.org>
To: Manish Jaggi <mjaggi@caviumnetworks.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Alex Williamson <alex.williamson@redhat.com>,
"Daney, David" <David.Daney@cavium.com>,
bhelgaas@google.com
Subject: Re: [PATCH] pci: quirk cavium: Add device ID range check
Date: Thu, 30 Mar 2017 18:53:06 -0500 [thread overview]
Message-ID: <20170330235306.GD3912@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <43ff1f3f-b098-f25d-b9dc-9e8ef2278110@caviumnetworks.com>
On Fri, Mar 17, 2017 at 12:46:29PM +0530, Manish Jaggi wrote:
> ACS quirk applies to devices with ID in the range a000-a0XX.
> The patch adds a check.This matches on-chip pci devices for
> CN81xx/CN83xx/CN88xx
>
> This patch adds check to
> b404bcfbf0 : PCI: Add ACS quirk for all Cavium devices
>
> Signed-off-by: Manish Jaggi <mjaggi@cavium.com>
> Acked-by: David Daney <david.daney@cavium.com>
Applied with Alex's ack to pci/host-thunder for v4.12, thanks!
> ---
> drivers/pci/quirks.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index f754453..178242d 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -4094,6 +4094,9 @@ static int pci_quirk_cavium_acs(struct pci_dev *dev, u16 acs_flags)
> acs_flags &= ~(PCI_ACS_SV | PCI_ACS_TB | PCI_ACS_RR |
> PCI_ACS_CR | PCI_ACS_UF | PCI_ACS_DT);
> + if (!((dev->device >= 0xa000) && (dev->device <= 0xa0ff)))
> + return -ENOTTY;
> +
> return acs_flags ? 0 : 1;
> }
> --
> 2.7.4
>
>
prev parent reply other threads:[~2017-03-30 23:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-17 7:16 Manish Jaggi
2017-03-17 22:27 ` Alex Williamson
2017-03-30 23:53 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170330235306.GD3912@bhelgaas-glaptop.roam.corp.google.com \
--to=helgaas@kernel.org \
--cc=David.Daney@cavium.com \
--cc=alex.williamson@redhat.com \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mjaggi@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®