* [PATCH] eudyptula challenge
@ 2017-03-31 20:58 Chewie Lin
2017-03-31 20:58 ` [PATCH 01/01] drivers/staging/vt6656/main_usb.c: checkpatch warning Chewie Lin
0 siblings, 1 reply; 3+ messages in thread
From: Chewie Lin @ 2017-03-31 20:58 UTC (permalink / raw)
To: greg, forest, devel, linux-kernel
Hi greg and forest:
I hate to bother but one more, with better changelog.
I'm submitting this patch as part of Eudyptula challenge to fix a
coding style problem. Thanks for taking time on this trivial patch.
sl424
Chewie Lin (1):
drivers/staging/vt6656/main_usb.c: checkpatch warning
drivers/staging/vt6656/main_usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.10.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 01/01] drivers/staging/vt6656/main_usb.c: checkpatch warning
2017-03-31 20:58 [PATCH] eudyptula challenge Chewie Lin
@ 2017-03-31 20:58 ` Chewie Lin
2017-03-31 21:52 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Chewie Lin @ 2017-03-31 20:58 UTC (permalink / raw)
To: greg, forest, devel, linux-kernel
Replace string with formatted arguments in the dev_warn() call. It removes
the checkpatch warning.
Signed-off-by: Chewie Lin <linsh@oregonstate.edu>
---
drivers/staging/vt6656/main_usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c
index 9e074e9..2d9e7af 100644
--- a/drivers/staging/vt6656/main_usb.c
+++ b/drivers/staging/vt6656/main_usb.c
@@ -414,7 +414,7 @@ static void usb_device_reset(struct vnt_private *priv)
status = usb_reset_device(priv->usb);
if (status)
dev_warn(&priv->usb->dev,
- "usb_device_reset fail status=%d\n", status);
+ "%s=%d\n", "usb_device_reset fail status", status);
}
static void vnt_free_int_bufs(struct vnt_private *priv)
--
2.10.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 01/01] drivers/staging/vt6656/main_usb.c: checkpatch warning
2017-03-31 20:58 ` [PATCH 01/01] drivers/staging/vt6656/main_usb.c: checkpatch warning Chewie Lin
@ 2017-03-31 21:52 ` Randy Dunlap
0 siblings, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2017-03-31 21:52 UTC (permalink / raw)
To: Chewie Lin, greg, forest, devel, linux-kernel
On 03/31/17 13:58, Chewie Lin wrote:
> Replace string with formatted arguments in the dev_warn() call. It removes
> the checkpatch warning.
Tell us what the warning was.
and then see if the patch fixes that warning.
> Signed-off-by: Chewie Lin <linsh@oregonstate.edu>
> ---
> drivers/staging/vt6656/main_usb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c
> index 9e074e9..2d9e7af 100644
> --- a/drivers/staging/vt6656/main_usb.c
> +++ b/drivers/staging/vt6656/main_usb.c
> @@ -414,7 +414,7 @@ static void usb_device_reset(struct vnt_private *priv)
> status = usb_reset_device(priv->usb);
> if (status)
> dev_warn(&priv->usb->dev,
> - "usb_device_reset fail status=%d\n", status);
> + "%s=%d\n", "usb_device_reset fail status", status);
> }
>
> static void vnt_free_int_bufs(struct vnt_private *priv)
>
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-31 21:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-31 20:58 [PATCH] eudyptula challenge Chewie Lin
2017-03-31 20:58 ` [PATCH 01/01] drivers/staging/vt6656/main_usb.c: checkpatch warning Chewie Lin
2017-03-31 21:52 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®