From: Chewie Lin <linsh@oregonstate.edu>
To: greg@kroah.com, forest@alittletooquiet.net,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH 001/001] drivers/staging/vt6656/main_usb.c: checkpatch warning
Date: Fri, 31 Mar 2017 18:59:19 -0700 [thread overview]
Message-ID: <20170401015919.9181-2-linsh@oregonstate.edu> (raw)
In-Reply-To: <20170401015919.9181-1-linsh@oregonstate.edu>
Replace string with formatted arguments in the dev_warn() call. It removes
the checkpatch warning:
WARNING: Prefer using "%s", __func__ to embedded function names
#417: FILE: main_usb.c:417:
+ "usb_device_reset fail status=%d\n", status);
total: 0 errors, 1 warnings, 1058 lines checked
And after fix:
main_usb.c has no obvious style problems and is ready for submission.
Signed-off-by: Chewie Lin <linsh@oregonstate.edu>
---
drivers/staging/vt6656/main_usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c
index 9e074e9..2d9e7af 100644
--- a/drivers/staging/vt6656/main_usb.c
+++ b/drivers/staging/vt6656/main_usb.c
@@ -414,7 +414,7 @@ static void usb_device_reset(struct vnt_private *priv)
status = usb_reset_device(priv->usb);
if (status)
dev_warn(&priv->usb->dev,
- "usb_device_reset fail status=%d\n", status);
+ "%s=%d\n", "usb_device_reset fail status", status);
}
static void vnt_free_int_bufs(struct vnt_private *priv)
--
2.10.0
next prev parent reply other threads:[~2017-04-01 1:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-01 1:59 [PATCH] eudyptula challenge Chewie Lin
2017-04-01 1:59 ` Chewie Lin [this message]
2017-04-01 2:15 ` [PATCH 001/001] drivers/staging/vt6656/main_usb.c: checkpatch warning Randy Dunlap
2017-04-01 2:45 ` Joe Perches
2017-04-01 3:18 ` Chewie Lin
2017-04-01 3:33 ` Joe Perches
2017-04-01 2:16 ` Joe Perches
2017-04-01 3:32 ` Al Viro
2017-04-01 3:36 ` Joe Perches
2017-04-01 3:46 ` Al Viro
2017-04-01 3:52 ` Joe Perches
2017-04-01 4:08 ` Al Viro
2017-04-01 4:27 ` Joe Perches
2017-04-01 4:33 ` Chewie Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170401015919.9181-2-linsh@oregonstate.edu \
--to=linsh@oregonstate.edu \
--cc=devel@driverdev.osuosl.org \
--cc=forest@alittletooquiet.net \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®