From: Lee Jones <lee.jones@linaro.org>
To: Hugues Fruchet <hugues.fruchet@st.com>
Cc: linux-kernel@vger.kernel.org,
Benjamin Gaignard <benjamin.gaignard@linaro.org>,
Amelie DELAUNAY <amelie.delaunay@st.com>,
Patrice Chotard <patrice.chotard@st.com>
Subject: Re: [PATCH] mfd: stmpe: Fix bit clearing on STMPE1600
Date: Mon, 3 Apr 2017 11:29:21 +0100 [thread overview]
Message-ID: <20170403102921.biv4g42c7fazizsf@dell> (raw)
In-Reply-To: <1490947959-19597-1-git-send-email-hugues.fruchet@st.com>
On Fri, 31 Mar 2017, Hugues Fruchet wrote:
> GPIO bits clearing on pins assigned to STMPE1600
> had no effects due to missing "clear registers"
> settings within stmpe1600_regs[].
> STMPE1600 does not have dedicated "clear registers",
> but single "set/clear registers", hence stmpe1600_regs[]
> "clear registers" (STMPE_IDX_GPCR_XXX) must be set to
> same value as "set registers" (STMPE_IDX_GPSR_XXX), ie
> STMPE1600_REG_GPSR_XXX.
>
> Signed-off-by: Hugues Fruchet <hugues.fruchet@st.com>
> ---
> drivers/mfd/stmpe.c | 2 ++
> 1 file changed, 2 insertions(+)
Applied, thanks.
> diff --git a/drivers/mfd/stmpe.c b/drivers/mfd/stmpe.c
> index b0c7bcd..566caca 100644
> --- a/drivers/mfd/stmpe.c
> +++ b/drivers/mfd/stmpe.c
> @@ -568,6 +568,8 @@ static int stmpe811_get_altfunc(struct stmpe *stmpe, enum stmpe_block block)
> [STMPE_IDX_GPMR_CSB] = STMPE1600_REG_GPMR_MSB,
> [STMPE_IDX_GPSR_LSB] = STMPE1600_REG_GPSR_LSB,
> [STMPE_IDX_GPSR_CSB] = STMPE1600_REG_GPSR_MSB,
> + [STMPE_IDX_GPCR_LSB] = STMPE1600_REG_GPSR_LSB,
> + [STMPE_IDX_GPCR_CSB] = STMPE1600_REG_GPSR_MSB,
> [STMPE_IDX_GPDR_LSB] = STMPE1600_REG_GPDR_LSB,
> [STMPE_IDX_GPDR_CSB] = STMPE1600_REG_GPDR_MSB,
> [STMPE_IDX_IEGPIOR_LSB] = STMPE1600_REG_IEGPIOR_LSB,
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2017-04-03 10:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-31 8:12 Hugues Fruchet
2017-03-31 9:19 ` Patrice CHOTARD
2017-04-03 10:29 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170403102921.biv4g42c7fazizsf@dell \
--to=lee.jones@linaro.org \
--cc=amelie.delaunay@st.com \
--cc=benjamin.gaignard@linaro.org \
--cc=hugues.fruchet@st.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patrice.chotard@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®