From: Patrice CHOTARD <patrice.chotard@st.com>
To: Hugues FRUCHET <hugues.fruchet@st.com>, Lee Jones <lee.jones@linaro.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Benjamin Gaignard" <benjamin.gaignard@linaro.org>,
Amelie DELAUNAY <amelie.delaunay@st.com>
Subject: Re: [PATCH] mfd: stmpe: Fix bit clearing on STMPE1600
Date: Fri, 31 Mar 2017 09:19:11 +0000 [thread overview]
Message-ID: <8a10fb24-3a8c-fcb1-fe5a-adcb5aef2255@st.com> (raw)
In-Reply-To: <1490947959-19597-1-git-send-email-hugues.fruchet@st.com>
Hi Hugues
On 03/31/2017 10:12 AM, Hugues Fruchet wrote:
> GPIO bits clearing on pins assigned to STMPE1600
> had no effects due to missing "clear registers"
> settings within stmpe1600_regs[].
> STMPE1600 does not have dedicated "clear registers",
> but single "set/clear registers", hence stmpe1600_regs[]
> "clear registers" (STMPE_IDX_GPCR_XXX) must be set to
> same value as "set registers" (STMPE_IDX_GPSR_XXX), ie
> STMPE1600_REG_GPSR_XXX.
>
> Signed-off-by: Hugues Fruchet <hugues.fruchet@st.com>
> ---
> drivers/mfd/stmpe.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mfd/stmpe.c b/drivers/mfd/stmpe.c
> index b0c7bcd..566caca 100644
> --- a/drivers/mfd/stmpe.c
> +++ b/drivers/mfd/stmpe.c
> @@ -568,6 +568,8 @@ static int stmpe811_get_altfunc(struct stmpe *stmpe, enum stmpe_block block)
> [STMPE_IDX_GPMR_CSB] = STMPE1600_REG_GPMR_MSB,
> [STMPE_IDX_GPSR_LSB] = STMPE1600_REG_GPSR_LSB,
> [STMPE_IDX_GPSR_CSB] = STMPE1600_REG_GPSR_MSB,
> + [STMPE_IDX_GPCR_LSB] = STMPE1600_REG_GPSR_LSB,
> + [STMPE_IDX_GPCR_CSB] = STMPE1600_REG_GPSR_MSB,
> [STMPE_IDX_GPDR_LSB] = STMPE1600_REG_GPDR_LSB,
> [STMPE_IDX_GPDR_CSB] = STMPE1600_REG_GPDR_MSB,
> [STMPE_IDX_IEGPIOR_LSB] = STMPE1600_REG_IEGPIOR_LSB,
>
Reviewed-by: Patrice Chotard <patrice.chotard@st.com>
Thanks
next prev parent reply other threads:[~2017-03-31 9:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-31 8:12 Hugues Fruchet
2017-03-31 9:19 ` Patrice CHOTARD [this message]
2017-04-03 10:29 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a10fb24-3a8c-fcb1-fe5a-adcb5aef2255@st.com \
--to=patrice.chotard@st.com \
--cc=amelie.delaunay@st.com \
--cc=benjamin.gaignard@linaro.org \
--cc=hugues.fruchet@st.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®