From: Peter Zijlstra <peterz@infradead.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Ingo Molnar <mingo@kernel.org>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Mike Galbraith <efault@gmx.de>, Ingo Molnar <mingo@elte.hu>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>
Subject: Re: [RFC PATCH] kernel: sched: Provide a pointer to the valid CPU mask
Date: Thu, 6 Apr 2017 11:46:35 +0200 [thread overview]
Message-ID: <20170406094635.iwkaewsbiud35q6b@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20170406092542.emc3lmqu2ywt3opy@linutronix.de>
On Thu, Apr 06, 2017 at 11:25:42AM +0200, Sebastian Andrzej Siewior wrote:
> > I.e. just have a counter and these two APIs:
> >
> > static inline void migrate_disable(void)
> > {
> > current->migration_disabled++;
> plus
> if (current->migration_disabled == 1)
> get_online_cpus()
You want that other hotplug fast hack crap you have in rt, no? Because
mainline will not get anything other than prempt_disable() for
migrate_disable().
> > }
> >
> > ...
> >
> > static inline void migrate_enable(void)
> > {
> > current->migration_disabled--;
> > }
> >
> > ... and make sure the scheduler migration code plus the CPU hotplug code considers
> > the counter.
>
> So on the sched part I need go through all places where it looks at the
> mask and make sure it ignores the CPU switch decision. This could be
> doable.
Don't sprinkle that around. Use a wrapper like say: tsk_cpus_allowed()
to encapsulate that logic :-)
next prev parent reply other threads:[~2017-04-06 9:46 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-04 18:42 Sebastian Andrzej Siewior
2017-04-05 7:39 ` Ingo Molnar
2017-04-05 8:37 ` Sebastian Andrzej Siewior
2017-04-06 6:16 ` Ingo Molnar
2017-04-06 7:38 ` Sebastian Andrzej Siewior
2017-04-06 8:01 ` Ingo Molnar
2017-04-06 9:25 ` Sebastian Andrzej Siewior
2017-04-06 9:46 ` Peter Zijlstra [this message]
2017-04-06 10:58 ` Thomas Gleixner
2017-04-06 11:41 ` Peter Zijlstra
2017-04-06 9:35 ` Peter Zijlstra
2017-04-06 9:42 ` Peter Zijlstra
2017-04-06 10:36 ` Thomas Gleixner
2017-04-06 11:02 ` Ingo Molnar
2017-04-06 11:10 ` Thomas Gleixner
2017-04-07 7:13 ` Ingo Molnar
2017-04-06 9:34 ` Peter Zijlstra
2017-04-06 9:32 ` Peter Zijlstra
2017-04-06 9:46 ` Sebastian Andrzej Siewior
2017-04-06 10:35 ` Peter Zijlstra
2017-04-06 10:47 ` Thomas Gleixner
2017-04-06 10:57 ` Peter Zijlstra
2017-04-06 11:03 ` Thomas Gleixner
2017-04-06 11:50 ` Peter Zijlstra
2017-04-06 11:56 ` Thomas Gleixner
2017-04-06 12:31 ` Peter Zijlstra
2017-04-11 1:38 ` [lkp-robot] [kernel] c1f943ee40: kernel_BUG_at_kernel/smpboot.c kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170406094635.iwkaewsbiud35q6b@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bigeasy@linutronix.de \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®