From: Viresh Kumar <viresh.kumar@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: Rafael Wysocki <rjw@rjwysocki.net>,
ulf.hansson@linaro.org, Kevin Hilman <khilman@linaro.org>,
Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>,
Stephen Boyd <sboyd@codeaurora.org>,
linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Vincent Guittot <vincent.guittot@linaro.org>,
lina.iyer@linaro.org, rnayak@codeaurora.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH V4 1/9] PM / OPP: Allow OPP table to be used for power-domains
Date: Mon, 10 Apr 2017 14:55:15 +0530 [thread overview]
Message-ID: <20170410092515.GF24555@vireshk-i7> (raw)
In-Reply-To: <20170324154451.ljszby3mhc4rlgnw@rob-hp-laptop>
On 24-03-17, 10:44, Rob Herring wrote:
> On Mon, Mar 20, 2017 at 03:02:13PM +0530, Viresh Kumar wrote:
> > Power-domains need to express their active states in DT and what's
> > better than OPP table for that.
> >
> > This patch allows power-domains to reuse OPP tables to express their
> > active states. The "opp-hz" property isn't a required property anymore
> > as power-domains may not always use them.
>
> Then maybe you shouldn't be trying to make OPP table work here. At that
> point you just need a table of voltage(s) per performance state?
Because that's what Kevin strongly recommended in the previous
versions.
@Kevin: Would you like to reply here ?
> > Add a new property "domain-performance-state", which will contain
> > positive integer values to represent performance levels of the
> > power-domains as described in this patch.
>
> Why not reference the OPP entries from the domain:
>
> performance-states = <&opp1>, <&opp2>;
Because that would require additional code in the OPP core to parse
these then. Right now it is quite straight forward with the bindings I
presented.
> Just thinking out loud, not saying that is what you should do. The
> continual evolution of power (management) domain, idle state, and OPP
> bindings is getting tiring.
I agree :)
--
viresh
next prev parent reply other threads:[~2017-04-10 9:26 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-20 9:32 [PATCH V4 0/9] PM / Domains: Implement domain performance states Viresh Kumar
2017-03-20 9:32 ` [PATCH V4 1/9] PM / OPP: Allow OPP table to be used for power-domains Viresh Kumar
2017-03-24 15:44 ` Rob Herring
2017-04-10 9:25 ` Viresh Kumar [this message]
2017-04-10 9:50 ` Viresh Kumar
2017-04-12 16:49 ` Sudeep Holla
2017-04-13 5:37 ` Viresh Kumar
2017-04-13 13:42 ` Sudeep Holla
2017-04-17 5:27 ` Viresh Kumar
2017-04-18 16:01 ` Sudeep Holla
2017-04-19 10:11 ` Viresh Kumar
2017-04-19 11:47 ` Viresh Kumar
2017-04-19 13:58 ` Sudeep Holla
2017-04-20 5:25 ` Viresh Kumar
2017-04-20 8:23 ` Ulf Hansson
2017-04-20 9:33 ` Viresh Kumar
2017-04-20 9:51 ` Sudeep Holla
2017-04-20 9:43 ` Sudeep Holla
2017-04-20 9:52 ` Viresh Kumar
2017-04-23 22:07 ` Kevin Hilman
2017-04-26 4:32 ` Rajendra Nayak
2017-04-26 13:55 ` Mark Brown
2017-04-27 9:42 ` Sudeep Holla
2017-04-27 10:50 ` Rajendra Nayak
2017-04-28 5:00 ` Viresh Kumar
2017-04-28 9:44 ` Sudeep Holla
2017-04-28 11:12 ` Viresh Kumar
2017-04-30 12:49 ` Mark Brown
2017-05-03 11:21 ` Sudeep Holla
2017-05-14 9:55 ` Mark Brown
2017-04-12 17:05 ` Sudeep Holla
2017-04-13 5:50 ` Viresh Kumar
2017-04-13 13:43 ` Sudeep Holla
2017-04-17 5:33 ` Viresh Kumar
2017-04-18 16:03 ` Sudeep Holla
2017-04-19 10:12 ` Viresh Kumar
2017-03-20 9:32 ` [PATCH V4 2/9] PM / Domains: Use OPP tables " Viresh Kumar
2017-04-12 16:58 ` Sudeep Holla
2017-04-13 6:03 ` Viresh Kumar
2017-04-13 13:45 ` Sudeep Holla
2017-03-20 9:32 ` [PATCH V4 3/9] PM / QOS: Keep common notifier list for genpd constraints Viresh Kumar
2017-04-19 14:06 ` Ulf Hansson
2017-04-20 4:45 ` [PATCH V5 " Viresh Kumar
2017-03-20 9:32 ` [PATCH V4 4/9] PM / QOS: Add DEV_PM_QOS_PERFORMANCE request Viresh Kumar
2017-04-19 14:07 ` Ulf Hansson
2017-04-20 4:34 ` Viresh Kumar
2017-04-20 4:46 ` [PATCH V5 " Viresh Kumar
2017-04-20 6:53 ` Ulf Hansson
2017-03-20 9:32 ` [PATCH V4 5/9] PM / OPP: Add support to parse OPP table for power-domains Viresh Kumar
2017-03-20 9:32 ` [PATCH V4 6/9] PM / OPP: Add dev_pm_opp_find_dps() helper Viresh Kumar
2017-03-20 9:32 ` [PATCH V4 7/9] PM / domain: Register for PM QOS performance notifier Viresh Kumar
2017-04-20 4:46 ` [PATCH V5 " Viresh Kumar
2017-03-20 9:32 ` [PATCH V4 8/9] PM / Domain: Add struct device to genpd Viresh Kumar
2017-03-20 9:32 ` [PATCH V4 9/9] PM / Domain: Add support to parse domain's OPP table Viresh Kumar
2017-04-12 14:24 ` [PATCH V4 0/9] PM / Domains: Implement domain performance states Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170410092515.GF24555@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=khilman@linaro.org \
--cc=lina.iyer@linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
--cc=rnayak@codeaurora.org \
--cc=robh@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=ulf.hansson@linaro.org \
--cc=vincent.guittot@linaro.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®