From: Sudeep Holla <sudeep.holla@arm.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
Rafael Wysocki <rjw@rjwysocki.net>,
ulf.hansson@linaro.org, Kevin Hilman <khilman@linaro.org>,
Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>,
Stephen Boyd <sboyd@codeaurora.org>,
linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Vincent Guittot <vincent.guittot@linaro.org>,
robh+dt@kernel.org, lina.iyer@linaro.org, rnayak@codeaurora.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH V4 1/9] PM / OPP: Allow OPP table to be used for power-domains
Date: Wed, 19 Apr 2017 14:58:00 +0100 [thread overview]
Message-ID: <9dee7c0d-e5f4-9fcd-3c92-bf7ec9d43a3b@arm.com> (raw)
In-Reply-To: <20170419114740.GD5436@vireshk-i7>
On 19/04/17 12:47, Viresh Kumar wrote:
> On 18-04-17, 17:01, Sudeep Holla wrote:
>> Understood. I would incline towards reusing regulators we that's what is
>
> It can be just a regulator, but it can be anything else as well. That
> entity may have its own clock/volt/current tunables, etc.
>
Agreed.
>> changed behind the scene. Calling this operating performance point
>> is misleading and doesn't align well with existing specs/features.
>
> Yeah, but there are no voltage levels available here and that doesn't
> fit as a regulator then.
>
We can't dismiss just based on that. We do have systems where
performance index is mapped to clocks though it may not be 1:1 mapping.
I am not disagreeing here, just trying to understand it better.
>> Understood. We have exactly same thing with SCPI but it controls both
>> frequency and voltage referred as operating points. In general, this OPP
>> terminology is used in SCPI/ACPI/SCMI specifications as both frequency
>> and voltage control. I am bit worried that this binding might introduce
>> confusions on the definitions. But it can be reworded/renamed easily if
>> required.
>
> Yeah, so far we have been looking at OPPs as freq-voltage pairs ONLY
> and that is changing. I am not sure if it going in the wrong
> direction really. Without frequency also it is an operating point for
> the domain. Isn't it?
>
Yes, I completely agree. I am not saying the direction is wrong. I am
saying it's confusing and binding needs to be more clear.
On the contrary(playing devil's advocate here), we can treat all
existing regulators alone as OPP then if you strip the voltages and
treat it as abstract number. So if the firmware handles more than just
regulators, I agree. At the same time, I would have preferred firmware
to even abstract the frequency like ACPI CPPC. It would be good to get
more information on what exactly that firmware handles.
I am just more cautious here since we are designing generic bindings and
changing generic code, we need to understand what that firmware supports
and how it may evolve(so that we can maintain DT compatibility)
I did a brief check and wanted to check if this is SMD/RPM regulators ?
--
Regards,
Sudeep
next prev parent reply other threads:[~2017-04-19 13:58 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-20 9:32 [PATCH V4 0/9] PM / Domains: Implement domain performance states Viresh Kumar
2017-03-20 9:32 ` [PATCH V4 1/9] PM / OPP: Allow OPP table to be used for power-domains Viresh Kumar
2017-03-24 15:44 ` Rob Herring
2017-04-10 9:25 ` Viresh Kumar
2017-04-10 9:50 ` Viresh Kumar
2017-04-12 16:49 ` Sudeep Holla
2017-04-13 5:37 ` Viresh Kumar
2017-04-13 13:42 ` Sudeep Holla
2017-04-17 5:27 ` Viresh Kumar
2017-04-18 16:01 ` Sudeep Holla
2017-04-19 10:11 ` Viresh Kumar
2017-04-19 11:47 ` Viresh Kumar
2017-04-19 13:58 ` Sudeep Holla [this message]
2017-04-20 5:25 ` Viresh Kumar
2017-04-20 8:23 ` Ulf Hansson
2017-04-20 9:33 ` Viresh Kumar
2017-04-20 9:51 ` Sudeep Holla
2017-04-20 9:43 ` Sudeep Holla
2017-04-20 9:52 ` Viresh Kumar
2017-04-23 22:07 ` Kevin Hilman
2017-04-26 4:32 ` Rajendra Nayak
2017-04-26 13:55 ` Mark Brown
2017-04-27 9:42 ` Sudeep Holla
2017-04-27 10:50 ` Rajendra Nayak
2017-04-28 5:00 ` Viresh Kumar
2017-04-28 9:44 ` Sudeep Holla
2017-04-28 11:12 ` Viresh Kumar
2017-04-30 12:49 ` Mark Brown
2017-05-03 11:21 ` Sudeep Holla
2017-05-14 9:55 ` Mark Brown
2017-04-12 17:05 ` Sudeep Holla
2017-04-13 5:50 ` Viresh Kumar
2017-04-13 13:43 ` Sudeep Holla
2017-04-17 5:33 ` Viresh Kumar
2017-04-18 16:03 ` Sudeep Holla
2017-04-19 10:12 ` Viresh Kumar
2017-03-20 9:32 ` [PATCH V4 2/9] PM / Domains: Use OPP tables " Viresh Kumar
2017-04-12 16:58 ` Sudeep Holla
2017-04-13 6:03 ` Viresh Kumar
2017-04-13 13:45 ` Sudeep Holla
2017-03-20 9:32 ` [PATCH V4 3/9] PM / QOS: Keep common notifier list for genpd constraints Viresh Kumar
2017-04-19 14:06 ` Ulf Hansson
2017-04-20 4:45 ` [PATCH V5 " Viresh Kumar
2017-03-20 9:32 ` [PATCH V4 4/9] PM / QOS: Add DEV_PM_QOS_PERFORMANCE request Viresh Kumar
2017-04-19 14:07 ` Ulf Hansson
2017-04-20 4:34 ` Viresh Kumar
2017-04-20 4:46 ` [PATCH V5 " Viresh Kumar
2017-04-20 6:53 ` Ulf Hansson
2017-03-20 9:32 ` [PATCH V4 5/9] PM / OPP: Add support to parse OPP table for power-domains Viresh Kumar
2017-03-20 9:32 ` [PATCH V4 6/9] PM / OPP: Add dev_pm_opp_find_dps() helper Viresh Kumar
2017-03-20 9:32 ` [PATCH V4 7/9] PM / domain: Register for PM QOS performance notifier Viresh Kumar
2017-04-20 4:46 ` [PATCH V5 " Viresh Kumar
2017-03-20 9:32 ` [PATCH V4 8/9] PM / Domain: Add struct device to genpd Viresh Kumar
2017-03-20 9:32 ` [PATCH V4 9/9] PM / Domain: Add support to parse domain's OPP table Viresh Kumar
2017-04-12 14:24 ` [PATCH V4 0/9] PM / Domains: Implement domain performance states Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9dee7c0d-e5f4-9fcd-3c92-bf7ec9d43a3b@arm.com \
--to=sudeep.holla@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=khilman@linaro.org \
--cc=lina.iyer@linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=ulf.hansson@linaro.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome