From: Viresh Kumar <viresh.kumar@linaro.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@redhat.com>,
linaro-kernel@lists.linaro.org, linux-kernel@vger.kernel.org,
Vincent Guittot <vincent.guittot@linaro.org>
Subject: Re: [PATCH 0/4] sched: Minor cleanups
Date: Mon, 10 Apr 2017 15:00:38 +0530 [thread overview]
Message-ID: <20170410093038.GG24555@vireshk-i7> (raw)
In-Reply-To: <20170327135805.t3pnkomktsm4j2vw@hirez.programming.kicks-ass.net>
On 27-03-17, 15:58, Peter Zijlstra wrote:
> On Thu, Mar 23, 2017 at 05:05:55PM +0530, Viresh Kumar wrote:
> > Hi,
> >
> > Here are few minor cleanups for the sched core. The first three tries to
> > avoid reinitializing memory which is already set to zero and the last
> > one drops an unused statement.
> >
>
> I'm OK with the kzalloc/memset thing,
I assume that you are fine with removal of memset as done in the first
3 patches. Or you are fine with just the first patch?
> but I'd prefer to keep all those
> other bits.
>
> Yes they're superfluous, but this is init code, so nobody cares about
> performance and having those things explitic makes it easier to read.
Sure.
> As to the very latest patch, that's there so that if/when we extend that
> array we can simply continue. Also its more symmetric/consistent. Any
> half sane DCE pass should get rid of it anyway, as the result is unused.
But we aren't going to extend the array all the time and keeping a
statement like that just for symmetry doesn't sound that great :).
Anyway, I will drop the last patch as you suggested.
--
viresh
prev parent reply other threads:[~2017-04-10 9:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-23 11:35 Viresh Kumar
2017-03-23 11:35 ` [PATCH 1/4] sched: topology: drop memset() from init_rootdomain() Viresh Kumar
2017-03-23 11:35 ` [PATCH 2/4] sched: cpudeadline: don't re-initialize struct cpudl Viresh Kumar
2017-03-23 11:35 ` [PATCH 3/4] sched: cpupri: don't re-initialize struct cpupri Viresh Kumar
2017-03-23 11:35 ` [PATCH 4/4] sched: core: drop useless expression from sched_init() Viresh Kumar
2017-03-27 13:58 ` [PATCH 0/4] sched: Minor cleanups Peter Zijlstra
2017-04-10 9:30 ` Viresh Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170410093038.GG24555@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®