* [PATCH v2] checkpatch: special audit for revert commit line
@ 2017-04-11 19:15 Wei Wang
2017-04-11 19:23 ` Joe Perches
0 siblings, 1 reply; 2+ messages in thread
From: Wei Wang @ 2017-04-11 19:15 UTC (permalink / raw)
To: apw, joe; +Cc: linux-kernel, Wei Wang
From: Wei Wang <wvw@google.com>
Currently checkpatch.pl does not recognize git's default
commit revert message and will complain about the hash format.
Add special audit for revert commit message line to fix it.
Signed-off-by: Wei Wang <wvw@google.com>
---
scripts/checkpatch.pl | 1 +
1 file changed, 1 insertion(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index baa3c7be04ad..9570db236ba3 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2539,6 +2539,7 @@ sub process {
# Check for git id commit length and improperly formed commit descriptions
if ($in_commit_log && !$commit_log_possible_stack_dump &&
$line !~ /^\s*(?:Link|Patchwork|http|https|BugLink):/i &&
+ $line !~ /^This reverts commit [0-9a-f]{7,40}/ &&
($line =~ /\bcommit\s+[0-9a-f]{5,}\b/i ||
($line =~ /(?:\s|^)[0-9a-f]{12,40}(?:[\s"'\(\[]|$)/i &&
$line !~ /[\<\[][0-9a-f]{12,40}[\>\]]/i &&
--
2.12.2.715.g7642488e1d-goog
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] checkpatch: special audit for revert commit line
2017-04-11 19:15 [PATCH v2] checkpatch: special audit for revert commit line Wei Wang
@ 2017-04-11 19:23 ` Joe Perches
0 siblings, 0 replies; 2+ messages in thread
From: Joe Perches @ 2017-04-11 19:23 UTC (permalink / raw)
To: Wei Wang, apw, Andrew Morton; +Cc: linux-kernel
On Tue, 2017-04-11 at 12:15 -0700, Wei Wang wrote:
> From: Wei Wang <wvw@google.com>
>
> Currently checkpatch.pl does not recognize git's default
> commit revert message and will complain about the hash format.
> Add special audit for revert commit message line to fix it.
>
> Signed-off-by: Wei Wang <wvw@google.com>
Acked-by: Joe Perches <joe@perches.com>
> ---
> scripts/checkpatch.pl | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index baa3c7be04ad..9570db236ba3 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2539,6 +2539,7 @@ sub process {
> # Check for git id commit length and improperly formed commit descriptions
> if ($in_commit_log && !$commit_log_possible_stack_dump &&
> $line !~ /^\s*(?:Link|Patchwork|http|https|BugLink):/i &&
> + $line !~ /^This reverts commit [0-9a-f]{7,40}/ &&
> ($line =~ /\bcommit\s+[0-9a-f]{5,}\b/i ||
> ($line =~ /(?:\s|^)[0-9a-f]{12,40}(?:[\s"'\(\[]|$)/i &&
> $line !~ /[\<\[][0-9a-f]{12,40}[\>\]]/i &&
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-11 19:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-11 19:15 [PATCH v2] checkpatch: special audit for revert commit line Wei Wang
2017-04-11 19:23 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®