mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] clk: sunxi-ng: fix build failure in ccu-sun9i-a80 driver
@ 2017-04-10 12:15 Tobias Regnery
  2017-04-13  9:11 ` Maxime Ripard
  0 siblings, 1 reply; 2+ messages in thread
From: Tobias Regnery @ 2017-04-10 12:15 UTC (permalink / raw)
  To: maxime.ripard, linux-clk, linux-kernel; +Cc: Tobias Regnery

The ccu-sun9i-a80 driver uses the ccu_mult_ops struct, but unlike the other
users it doesen't select the corresponding Kconfig symbol under which the
struct is compiled in.

This results in the following link error with CONFIG_SUN9I_A80_CCU=y and
CONFIG_SUNXI_CCU_MULT=n:

drivers/built-in.o:(.data+0x2d638): undefined reference to 'ccu_mult_ops'

Fix this by explicitly selecting CONFIG_SUNXI_CCU_MULT like the other
users of the struct.

Signed-off-by: Tobias Regnery <tobias.regnery@gmail.com>
---
 drivers/clk/sunxi-ng/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/sunxi-ng/Kconfig b/drivers/clk/sunxi-ng/Kconfig
index fbd3f8cd5c22..64088e599404 100644
--- a/drivers/clk/sunxi-ng/Kconfig
+++ b/drivers/clk/sunxi-ng/Kconfig
@@ -143,6 +143,7 @@ config SUN8I_V3S_CCU
 config SUN9I_A80_CCU
 	bool "Support for the Allwinner A80 CCU"
 	select SUNXI_CCU_DIV
+	select SUNXI_CCU_MULT
 	select SUNXI_CCU_GATE
 	select SUNXI_CCU_NKMP
 	select SUNXI_CCU_NM
-- 
2.11.0

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] clk: sunxi-ng: fix build failure in ccu-sun9i-a80 driver
  2017-04-10 12:15 [PATCH] clk: sunxi-ng: fix build failure in ccu-sun9i-a80 driver Tobias Regnery
@ 2017-04-13  9:11 ` Maxime Ripard
  0 siblings, 0 replies; 2+ messages in thread
From: Maxime Ripard @ 2017-04-13  9:11 UTC (permalink / raw)
  To: Tobias Regnery; +Cc: linux-clk, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 733 bytes --]

On Mon, Apr 10, 2017 at 02:15:44PM +0200, Tobias Regnery wrote:
> The ccu-sun9i-a80 driver uses the ccu_mult_ops struct, but unlike the other
> users it doesen't select the corresponding Kconfig symbol under which the
> struct is compiled in.
> 
> This results in the following link error with CONFIG_SUN9I_A80_CCU=y and
> CONFIG_SUNXI_CCU_MULT=n:
> 
> drivers/built-in.o:(.data+0x2d638): undefined reference to 'ccu_mult_ops'
> 
> Fix this by explicitly selecting CONFIG_SUNXI_CCU_MULT like the other
> users of the struct.
> 
> Signed-off-by: Tobias Regnery <tobias.regnery@gmail.com>

Applied, thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-04-13  9:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-10 12:15 [PATCH] clk: sunxi-ng: fix build failure in ccu-sun9i-a80 driver Tobias Regnery
2017-04-13  9:11 ` Maxime Ripard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®