Re: [PATCH v2] sched: Enabled schedstat when schedstat tracepoints are enabled

[Mel Gorman <mgorman@suse.de>]

On Wed, Apr 12, 2017 at 10:56:07PM -0400, Steven Rostedt wrote:
> From: Steven Rostedt (VMware) <rostedt@goodmis.org>
> 
> During my tests, I see this in my dmesg:
> 
> "Scheduler tracepoints stat_sleep, stat_iowait, stat_blocked and
> stat_runtime require the kernel parameter schedstats=enabled or
> kernel.sched_schedstats=1"
> 
> And found the commit:
> 
> cb2517653fc ("sched/debug: Make schedstats a runtime tunable that is
> disabled by default")
> 
> Which states:
> 
> "For tracepoints, there is a simple warning as it's not safe to activate
>  schedstats in the context when it's known the tracepoint may be wanted
>  but is unavailable."
> 
> I'm assuming that Mel did not know about the TRACE_EVENT_FN() and
> DEFINE_EVENT_FN() that allow for callbacks for tracepoints as they are
> enabled and disabled. I do not see any reason for not enabling
> schedstat when one of its tracepoints are enabled.
> 
> The state of schedstat is saved when the first tracepoint is enabled,
> and that state is put back when the tracepoints are disabled.
> 
> Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

You're right, I wasn't aware. Patch looks ok. When it triggers, there
will be a short interval of garbage numbers but that's the same as what
happens currently. It's not deliberate action any more that would flag
to the user that there is a hazard but I think it'll be manageable.

Acked-by: Mel Gorman <mgorman@suse.de>

Thanks Steven.

-- 
Mel Gorman
SUSE Labs