From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Horia Geantă" <horia.geanta@nxp.com>
Cc: Stuart Yoder <stuyoder@gmail.com>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
Haiying Wang <haiying.wang@nxp.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
Roy Pledge <roy.pledge@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] bus: fsl-mc: dpio: fix alter FQ state command
Date: Fri, 21 Apr 2017 17:47:34 +0300 [thread overview]
Message-ID: <20170421144734.7nr2dnqcltgov74v@mwanda> (raw)
In-Reply-To: <VI1PR0401MB2591DAF5E8813DD27C7AA4F8981A0@VI1PR0401MB2591.eurprd04.prod.outlook.com>
On Fri, Apr 21, 2017 at 01:50:24PM +0000, Horia Geantă wrote:
> Let me know whether keeping code similar would be preferred or not.
>
Keeping the code similar to the surrounding is never a valid argument
but especially not in staging/. If only 1 line is nice in the whole
file, at least that's better than nothing.
regards,
dan carpenter
next prev parent reply other threads:[~2017-04-21 15:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 12:00 Horia Geantă
2017-04-21 13:31 ` Stuart Yoder
2017-04-21 13:50 ` Horia Geantă
2017-04-21 14:47 ` Dan Carpenter [this message]
2017-04-22 6:44 ` [PATCH v2] " Horia Geantă
2017-04-28 10:31 ` Greg KH
2017-04-28 10:47 ` Horia Geantă
2017-04-28 12:22 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170421144734.7nr2dnqcltgov74v@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=haiying.wang@nxp.com \
--cc=horia.geanta@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roy.pledge@nxp.com \
--cc=stuyoder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®