mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: "Horia Geantă" <horia.geanta@nxp.com>
Cc: Roy Pledge <roy.pledge@nxp.com>,
	"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
	Stuart Yoder <stuyoder@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Haiying Wang <haiying.wang@nxp.com>
Subject: Re: [PATCH v2] bus: fsl-mc: dpio: fix alter FQ state command
Date: Fri, 28 Apr 2017 14:22:17 +0200	[thread overview]
Message-ID: <20170428122217.GA18081@kroah.com> (raw)
In-Reply-To: <VI1PR0401MB2591849E9898C03ACE04A99798130@VI1PR0401MB2591.eurprd04.prod.outlook.com>

On Fri, Apr 28, 2017 at 10:47:14AM +0000, Horia Geantă wrote:
> On 4/28/2017 1:32 PM, Greg KH wrote:
> > On Sat, Apr 22, 2017 at 09:44:49AM +0300, Horia Geantă wrote:
> >> When checking the response verb, the valid bit should be masked out,
> >> since its value flips depending on what Response Register
> >> (RR0 /RR1) it's been read from.
> >>
> >> Fixes: 321eecb06bfb ("bus: fsl-mc: dpio: add QBMan portal APIs for DPAA2")
> >> Signed-off-by: Horia Geantă <horia.geanta@nxp.com>
> >> ---
> >> v2: use QBMAN_RESULT_MASK instead of hard-coded mask
> > 
> > Why are you not using 'staging' in your subject line?
> > 
> I was not aware this is required and followed the statistics:
> 
> git log --oneline drivers/staging/fsl-mc/bus/dpio/
> 141a10aead9c staging: fsl-mc/dpio: Fix early writing of valid bit
> 993fec7e11ca bus: fsl-mc: dpio: add the DPAA2 DPIO object driver
> 780b626323d7 bus: fsl-mc: dpio: add the DPAA2 DPIO service interface
> 321eecb06bfb bus: fsl-mc: dpio: add QBMan portal APIs for DPAA2
> 2704aedb5c21 bus: fsl-mc: dpio: add APIs for DPIO objects
> 0e6437941e44 bus: fsl-mc: dpio: add DPIO driver overview document
> 
> Do I have to resubmit?

No, I have edited the subject, it should be "staging: fsl-mc: bus: ..."
for future patches.

thanks,

greg k-h

      reply	other threads:[~2017-04-28 12:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-21 12:00 [PATCH] " Horia Geantă
2017-04-21 13:31 ` Stuart Yoder
2017-04-21 13:50   ` Horia Geantă
2017-04-21 14:47     ` Dan Carpenter
2017-04-22  6:44       ` [PATCH v2] " Horia Geantă
2017-04-28 10:31         ` Greg KH
2017-04-28 10:47           ` Horia Geantă
2017-04-28 12:22             ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170428122217.GA18081@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=haiying.wang@nxp.com \
    --cc=horia.geanta@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roy.pledge@nxp.com \
    --cc=stuyoder@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome