mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Jens Axboe <axboe@fb.com>
Cc: Paolo Valente <paolo.valente@linaro.org>,
	Arnd Bergmann <arnd@arndb.de>, Tejun Heo <tj@kernel.org>,
	Li Zefan <lizefan@huawei.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Daniel Mack <daniel@zonque.org>, Ingo Molnar <mingo@kernel.org>,
	cgroups@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] cgroup: define empty cftype structure for !CONFIG_CGROUPS
Date: Fri, 21 Apr 2017 23:41:43 +0200	[thread overview]
Message-ID: <20170421214206.1825504-1-arnd@arndb.de> (raw)

There is a new forward declaration for two global cftype arrays, but
that fails to build when CONFIG_CGROUPS is disabled:

In file included from /git/arm-soc/block/bfq-iosched.c:105:0:
block/bfq-iosched.h:820:22: error: array type has incomplete element type 'struct cftype'
 extern struct cftype bfq_blkcg_legacy_files[];
 extern struct cftype bfq_blkg_files[];

This adds an empty definition for the type to make it build again.

Fixes: ea25da48086d ("block, bfq: split bfq-iosched.c into multiple source files")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 include/linux/cgroup-defs.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/include/linux/cgroup-defs.h b/include/linux/cgroup-defs.h
index 21745946cae1..cb3cc9588622 100644
--- a/include/linux/cgroup-defs.h
+++ b/include/linux/cgroup-defs.h
@@ -556,6 +556,9 @@ static inline void cgroup_threadgroup_change_end(struct task_struct *tsk)
 
 #else	/* CONFIG_CGROUPS */
 
+struct cftype {
+};
+
 #define CGROUP_SUBSYS_COUNT 0
 
 static inline void cgroup_threadgroup_change_begin(struct task_struct *tsk)
-- 
2.9.0

             reply	other threads:[~2017-04-21 21:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-21 21:41 Arnd Bergmann [this message]
2017-04-21 21:56 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170421214206.1825504-1-arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=axboe@fb.com \
    --cc=cgroups@vger.kernel.org \
    --cc=daniel@zonque.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=mingo@kernel.org \
    --cc=paolo.valente@linaro.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®