From: Jens Axboe <axboe@fb.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Paolo Valente <paolo.valente@linaro.org>,
Tejun Heo <tj@kernel.org>, "Li Zefan" <lizefan@huawei.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Daniel Mack <daniel@zonque.org>, Ingo Molnar <mingo@kernel.org>,
<cgroups@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cgroup: define empty cftype structure for !CONFIG_CGROUPS
Date: Fri, 21 Apr 2017 15:56:36 -0600 [thread overview]
Message-ID: <87094d9f-c6eb-567c-74d9-ff00e4ae5b3c@fb.com> (raw)
In-Reply-To: <20170421214206.1825504-1-arnd@arndb.de>
On 04/21/2017 03:41 PM, Arnd Bergmann wrote:
> There is a new forward declaration for two global cftype arrays, but
> that fails to build when CONFIG_CGROUPS is disabled:
>
> In file included from /git/arm-soc/block/bfq-iosched.c:105:0:
> block/bfq-iosched.h:820:22: error: array type has incomplete element type 'struct cftype'
> extern struct cftype bfq_blkcg_legacy_files[];
> extern struct cftype bfq_blkg_files[];
>
> This adds an empty definition for the type to make it build again.
This was already fixed up yesterday:
http://git.kernel.dk/cgit/linux-block/commit/?h=for-4.12/block&id=659b3394eb67a5e274d7e7348633b508510a5c8f
--
Jens Axboe
prev parent reply other threads:[~2017-04-21 21:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 21:41 Arnd Bergmann
2017-04-21 21:56 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87094d9f-c6eb-567c-74d9-ff00e4ae5b3c@fb.com \
--to=axboe@fb.com \
--cc=arnd@arndb.de \
--cc=cgroups@vger.kernel.org \
--cc=daniel@zonque.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=mingo@kernel.org \
--cc=paolo.valente@linaro.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®