mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Rajnikant Bhojani <rajnikant.bhojani@sibridgetech.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] check for null while iterating over a scatterlist table
Date: Tue, 25 Apr 2017 00:42:17 -0700	[thread overview]
Message-ID: <20170425074217.GA22533@infradead.org> (raw)
In-Reply-To: <1493105929-23353-1-git-send-email-rajnikant.bhojani@sibridgetech.com>

On Tue, Apr 25, 2017 at 01:08:49PM +0530, Rajnikant Bhojani wrote:
> during iterating over a scatterlist table also need to check for NULL
> along with number of scatterlist

Not sure this is a good idea.  Callers expect to iterate over the
full number in general.  Exiting early just papers over the bug
instead of fixing it.  A WARN_ON for this case might be a better idea.

  reply	other threads:[~2017-04-25  7:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-25  7:38 Rajnikant Bhojani
2017-04-25  7:42 ` Christoph Hellwig [this message]
2017-04-25  7:39 Rajnikant Bhojani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170425074217.GA22533@infradead.org \
    --to=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rajnikant.bhojani@sibridgetech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®