From: "Tobin C. Harding" <me@tobin.cc>
To: Ilia Sergachev <ilia.sergachev@unibas.ch>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: ks7010: fix block comment style in ks_wlan_net.c
Date: Wed, 26 Apr 2017 13:12:11 +1000 [thread overview]
Message-ID: <20170426031211.GB18468@eros> (raw)
In-Reply-To: <20170425205925.20439-1-ilia.sergachev@unibas.ch>
On Tue, Apr 25, 2017 at 10:59:25PM +0200, Ilia Sergachev wrote:
> This is a patch to the ks_wlan_net.c file that fixes up the following warning
> found by the checkpatch.pl tool:
> WARNING: Block comments use a trailing */ on a separate line
Good work resubmitting this following Greg's comments. May I suggest
some ways to hasten your success.
Note firstly, that I appreciate that writing the gitlog message is
very difficult to do well. I am by no means an expert.
- You don't need to mention the file, especially not in the subject. We
can see the files changed from the patch itself.
- You should refrain from using 'this patch', the subject (as in
subject, object, verb) is implicit.
See Documentation/process/submitting-patches.rst (Section 2: Describe
your changes).
Example
Checkpatch emits WARNING: Block comments use a trailing */ on a
separate line.
Move trailing */ to separate line.
Good luck,
Tobin.
next prev parent reply other threads:[~2017-04-26 3:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-25 20:59 Ilia Sergachev
2017-04-26 3:12 ` Tobin C. Harding [this message]
2017-04-26 8:18 ` [PATCH v2] Staging: ks7010: style fix Ilia Sergachev
2017-04-26 8:28 ` Greg Kroah-Hartman
2017-04-26 8:38 ` Ilia Sergachev
2017-04-26 10:37 ` Tobin C. Harding
2017-04-26 10:45 ` Dan Carpenter
2017-04-26 11:00 ` [PATCH v3] staging: ks7010: fix block comment style Ilia Sergachev
2017-04-26 22:50 ` Tobin C. Harding
2017-04-28 9:45 ` Greg Kroah-Hartman
2017-04-28 10:35 ` [PATCH v4] " Ilia Sergachev
2017-04-28 12:20 ` Greg Kroah-Hartman
2017-04-28 13:01 ` Ilia Sergachev
2017-04-30 9:11 ` Tobin C. Harding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170426031211.GB18468@eros \
--to=me@tobin.cc \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=ilia.sergachev@unibas.ch \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®