From: Jiri Slaby <jslaby@suse.cz>
To: akpm@linux-foundation.org
Cc: torvalds@linux-foundation.org, live-patching@vger.kernel.org,
linux-kernel@vger.kernel.org, Jiri Slaby <jslaby@suse.cz>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Michal Marek <mmarek@suse.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-kbuild@vger.kernel.org
Subject: [PATCH 1/7] DWARF: add option to preserve unwind info
Date: Fri, 5 May 2017 14:21:54 +0200 [thread overview]
Message-ID: <20170505122200.31436-1-jslaby@suse.cz> (raw)
It may be useful for some tools like gdb or latencytop. So we introduce
CONFIG_UNWIND_INFO. This information is also used by the DWARF unwinder in the
next patches.
In particular, we enable asynchronous unwind tables -- the out-of-band DWARF
info proper. And we also let the linker to generate an index for a fast binary
lookup (eh-frame-hdr).
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Michal Marek <mmarek@suse.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: x86@kernel.org
Cc: linux-kbuild@vger.kernel.org
---
Makefile | 5 +++++
arch/x86/Makefile | 2 ++
arch/x86/entry/calling.h | 13 +++++++++++++
arch/x86/kernel/vmlinux.lds.S | 2 ++
lib/Kconfig.debug | 10 ++++++++++
5 files changed, 32 insertions(+)
diff --git a/Makefile b/Makefile
index 23cc5d65172b..0eabd1300c69 100644
--- a/Makefile
+++ b/Makefile
@@ -739,6 +739,11 @@ endif
KBUILD_CFLAGS += $(call cc-option, -fno-var-tracking-assignments)
+ifdef CONFIG_UNWIND_INFO
+KBUILD_CFLAGS += -fasynchronous-unwind-tables
+LDFLAGS_vmlinux += --eh-frame-hdr
+endif
+
ifdef CONFIG_DEBUG_INFO
ifdef CONFIG_DEBUG_INFO_SPLIT
KBUILD_CFLAGS += $(call cc-option, -gsplit-dwarf, -g)
diff --git a/arch/x86/Makefile b/arch/x86/Makefile
index 4430dd489620..a4ab13b383cb 100644
--- a/arch/x86/Makefile
+++ b/arch/x86/Makefile
@@ -212,7 +212,9 @@ KBUILD_CFLAGS += -pipe
# Workaround for a gcc prelease that unfortunately was shipped in a suse release
KBUILD_CFLAGS += -Wno-sign-compare
#
+ifneq ($(CONFIG_UNWIND_INFO),y)
KBUILD_CFLAGS += -fno-asynchronous-unwind-tables
+endif
KBUILD_CFLAGS += $(mflags-y)
KBUILD_AFLAGS += $(mflags-y)
diff --git a/arch/x86/entry/calling.h b/arch/x86/entry/calling.h
index 05ed3d393da7..fd2334ee62fd 100644
--- a/arch/x86/entry/calling.h
+++ b/arch/x86/entry/calling.h
@@ -48,6 +48,19 @@ For 32-bit we have the following conventions - kernel is built with
*/
+#if !defined(CONFIG_UNWIND_INFO) && defined(CONFIG_AS_CFI_SECTIONS) \
+ && defined(__ASSEMBLY__)
+ /*
+ * Emit CFI data in .debug_frame sections, not .eh_frame sections.
+ * The latter we currently just discard since we don't do DWARF
+ * unwinding at runtime. So only the offline DWARF information is
+ * useful to anyone. Note we should not use this directive if this
+ * file is used in the vDSO assembly, or if vmlinux.lds.S gets
+ * changed so it doesn't discard .eh_frame.
+ */
+ .cfi_sections .debug_frame
+#endif
+
#ifdef CONFIG_X86_64
/*
diff --git a/arch/x86/kernel/vmlinux.lds.S b/arch/x86/kernel/vmlinux.lds.S
index c8a3b61be0aa..7dfe103d4fae 100644
--- a/arch/x86/kernel/vmlinux.lds.S
+++ b/arch/x86/kernel/vmlinux.lds.S
@@ -345,7 +345,9 @@ SECTIONS
/* Sections to be discarded */
DISCARDS
/DISCARD/ : {
+#ifndef CONFIG_UNWIND_INFO
*(.eh_frame)
+#endif
}
}
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index e4587ebe52c7..e90125b6498e 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -45,6 +45,16 @@ config MESSAGE_LOGLEVEL_DEFAULT
by default. To change that, use loglevel=<x> in the kernel bootargs,
or pick a different CONSOLE_LOGLEVEL_DEFAULT configuration value.
+config UNWIND_INFO
+ bool "Compile the kernel with frame unwind information"
+ depends on !IA64 && !PARISC && !ARM
+ depends on !MODULES || !(MIPS || PPC || SUPERH || V850)
+ help
+ If you say Y here the resulting kernel image will be slightly larger
+ but not slower, and it will give very useful debugging information.
+ If you don't debug the kernel, you can say N, but we may not be able
+ to solve problems without frame unwind information or frame pointers.
+
config BOOT_PRINTK_DELAY
bool "Delay each boot printk message by N milliseconds"
depends on DEBUG_KERNEL && PRINTK && GENERIC_CALIBRATE_DELAY
--
2.12.2
next reply other threads:[~2017-05-05 12:22 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-05 12:21 Jiri Slaby [this message]
2017-05-05 12:21 ` [PATCH 2/7] DWARF: EH-frame based stack unwinding Jiri Slaby
2017-05-05 12:21 ` [PATCH 3/7] vmlinux.lds: preserve eh_frame for DWARF unwinder Jiri Slaby
2017-05-05 12:21 ` [PATCH 4/7] DWARF: initialize structures for kernel and modules Jiri Slaby
2017-05-05 12:21 ` [PATCH 5/7] unwinder: show_stack, check also ret_addr_p's contents Jiri Slaby
2017-05-05 12:21 ` [PATCH 6/7] unwinder: plug in the DWARF unwinder Jiri Slaby
2017-05-05 12:22 ` [PATCH 7/7] DWARF: add the config option Jiri Slaby
2017-05-05 19:57 ` Linus Torvalds
2017-05-06 7:19 ` Ingo Molnar
2017-05-10 7:46 ` Jiri Slaby
2017-05-06 14:24 ` Jiri Kosina
2017-05-07 16:55 ` Josh Poimboeuf
2017-05-07 17:59 ` Ingo Molnar
2017-05-07 18:08 ` hpa
2017-05-07 21:48 ` Josh Poimboeuf
2017-05-08 7:50 ` Vojtech Pavlik
2017-05-08 13:14 ` Josh Poimboeuf
2017-05-08 5:35 ` Andy Lutomirski
2017-05-08 6:15 ` Ingo Molnar
2017-05-08 14:40 ` Josh Poimboeuf
2017-05-08 18:57 ` hpa
2017-05-09 0:21 ` Andy Lutomirski
2017-05-09 1:38 ` Josh Poimboeuf
2017-05-09 2:31 ` Andy Lutomirski
2017-05-09 3:38 ` Josh Poimboeuf
2017-05-09 10:00 ` hpa
2017-05-09 14:58 ` Josh Poimboeuf
2017-05-09 16:46 ` H.J. Lu
2017-05-10 8:15 ` Jiri Slaby
2017-05-10 13:09 ` Josh Poimboeuf
2017-05-10 16:23 ` H.J. Lu
2017-05-09 18:47 ` Jiri Kosina
2017-05-09 19:22 ` Josh Poimboeuf
2017-05-10 8:32 ` Jiri Slaby
2017-05-10 13:13 ` Josh Poimboeuf
2017-05-23 7:07 ` Peter Zijlstra
2017-05-23 7:27 ` Ingo Molnar
2017-05-19 20:53 ` Josh Poimboeuf
2017-05-19 20:57 ` H. Peter Anvin
2017-05-19 20:59 ` H. Peter Anvin
2017-05-19 21:29 ` Josh Poimboeuf
2017-05-19 21:35 ` Josh Poimboeuf
2017-05-20 5:23 ` Andy Lutomirski
2017-05-20 16:20 ` Josh Poimboeuf
2017-05-20 17:19 ` Josh Poimboeuf
2017-05-20 20:01 ` H.J. Lu
2017-05-20 21:58 ` Andy Lutomirski
2017-05-20 22:20 ` H.J. Lu
2017-05-22 11:34 ` Jiri Kosina
2017-05-22 14:39 ` H.J. Lu
2017-05-22 21:07 ` H. Peter Anvin
2017-05-22 21:37 ` H. Peter Anvin
2017-05-22 22:11 ` Josh Poimboeuf
2017-05-20 20:16 ` Linus Torvalds
2017-05-20 21:56 ` Andy Lutomirski
2017-05-20 23:00 ` Linus Torvalds
2017-05-20 23:29 ` Linus Torvalds
2017-05-26 6:54 ` Jiri Slaby
2017-05-26 11:29 ` Jiri Slaby
2017-05-26 12:14 ` Josh Poimboeuf
2017-05-22 11:12 ` Ingo Molnar
2017-05-22 21:16 ` H. Peter Anvin
2017-05-22 23:23 ` Jiri Kosina
2017-05-23 5:49 ` Ingo Molnar
2017-05-26 19:16 ` hpa
2017-05-28 9:12 ` Ingo Molnar
2017-05-10 7:39 ` Jiri Slaby
2017-05-10 12:42 ` Josh Poimboeuf
2017-05-10 12:47 ` Jiri Slaby
2017-05-10 18:11 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170505122200.31436-1-jslaby@suse.cz \
--to=jslaby@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mmarek@suse.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®