From: Josh Poimboeuf <jpoimboe@redhat.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: "H.J. Lu" <hjl.tools@gmail.com>,
Andy Lutomirski <luto@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jiri Slaby <jslaby@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
live-patching@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
the arch/x86 maintainers <x86@kernel.org>,
Jiri Kosina <jikos@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 7/7] DWARF: add the config option
Date: Mon, 22 May 2017 17:11:16 -0500 [thread overview]
Message-ID: <20170522221116.onntuq7rinnqudcw@treble> (raw)
In-Reply-To: <863bff71-0574-5093-ff45-2d68aedba906@zytor.com>
On Mon, May 22, 2017 at 02:37:50PM -0700, H. Peter Anvin wrote:
> On 05/22/17 14:07, H. Peter Anvin wrote:
> > On 05/20/17 13:01, H.J. Lu wrote:
> >> On Sat, May 20, 2017 at 9:20 AM, Josh Poimboeuf <jpoimboe@redhat.com> wrote:
> >>
> >>>>
> >>>> (H.J., could we get a binutils feature that allows is to do:
> >>>>
> >>>> pushq %whatever
> >>>> .cfi_adjust_sp -8
> >>>> ...
> >>>> popq %whatever
> >>>> .cfi_adjust_sp 8
> >>>>
> >>
> >> Np. Compiler needs to generate this.
> >>
> >
> > For actual assembly we have such a feature, it is called macros.
> >
> > push/pop is the easy stuff; macros take care of that, but the real pain
> > is dealing with the flow of control.
> >
>
> My biggest beef with the CFI directives that gas uses is that there is
> that .cfi_remember_state/.cfi_restore_state doesn't have a way to
> specify more than one state. That makes it really hard to get sanity
> around control flow changes, especially with code that is intentionally
> out of line.
>
> That, and some of the CFI directives seem to be a bit ill-defined in
> their definition (are they even applicable to anything other than
> DWARF?) They almost seem to be referencing some external specification,
> but the only thing I'm finding is the DWARF documentation which is
> written in very different terms.
>
> The best description of what a personality routine is I found in an
> article by Ian Lance Taylor. It doesn't seem to be applicable to C as
> far as I can tell.
So my understanding is that there's stock DWARF (.debug_frame) and then
there's souped-up DWARF (.eh_frame), which is basically DWARF with a few
extensions.
The remember/restore state thing is stock DWARF (DW_CFA_remember_state
and DW_CFA_restore_state). The personality routine thing is in the
.eh_frame extension which is documented here:
http://refspecs.linuxfoundation.org/LSB_5.0.0/LSB-Core-generic/LSB-Core-generic/ehframechpt.html
--
Josh
next prev parent reply other threads:[~2017-05-22 22:11 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-05 12:21 [PATCH 1/7] DWARF: add option to preserve unwind info Jiri Slaby
2017-05-05 12:21 ` [PATCH 2/7] DWARF: EH-frame based stack unwinding Jiri Slaby
2017-05-05 12:21 ` [PATCH 3/7] vmlinux.lds: preserve eh_frame for DWARF unwinder Jiri Slaby
2017-05-05 12:21 ` [PATCH 4/7] DWARF: initialize structures for kernel and modules Jiri Slaby
2017-05-05 12:21 ` [PATCH 5/7] unwinder: show_stack, check also ret_addr_p's contents Jiri Slaby
2017-05-05 12:21 ` [PATCH 6/7] unwinder: plug in the DWARF unwinder Jiri Slaby
2017-05-05 12:22 ` [PATCH 7/7] DWARF: add the config option Jiri Slaby
2017-05-05 19:57 ` Linus Torvalds
2017-05-06 7:19 ` Ingo Molnar
2017-05-10 7:46 ` Jiri Slaby
2017-05-06 14:24 ` Jiri Kosina
2017-05-07 16:55 ` Josh Poimboeuf
2017-05-07 17:59 ` Ingo Molnar
2017-05-07 18:08 ` hpa
2017-05-07 21:48 ` Josh Poimboeuf
2017-05-08 7:50 ` Vojtech Pavlik
2017-05-08 13:14 ` Josh Poimboeuf
2017-05-08 5:35 ` Andy Lutomirski
2017-05-08 6:15 ` Ingo Molnar
2017-05-08 14:40 ` Josh Poimboeuf
2017-05-08 18:57 ` hpa
2017-05-09 0:21 ` Andy Lutomirski
2017-05-09 1:38 ` Josh Poimboeuf
2017-05-09 2:31 ` Andy Lutomirski
2017-05-09 3:38 ` Josh Poimboeuf
2017-05-09 10:00 ` hpa
2017-05-09 14:58 ` Josh Poimboeuf
2017-05-09 16:46 ` H.J. Lu
2017-05-10 8:15 ` Jiri Slaby
2017-05-10 13:09 ` Josh Poimboeuf
2017-05-10 16:23 ` H.J. Lu
2017-05-09 18:47 ` Jiri Kosina
2017-05-09 19:22 ` Josh Poimboeuf
2017-05-10 8:32 ` Jiri Slaby
2017-05-10 13:13 ` Josh Poimboeuf
2017-05-23 7:07 ` Peter Zijlstra
2017-05-23 7:27 ` Ingo Molnar
2017-05-19 20:53 ` Josh Poimboeuf
2017-05-19 20:57 ` H. Peter Anvin
2017-05-19 20:59 ` H. Peter Anvin
2017-05-19 21:29 ` Josh Poimboeuf
2017-05-19 21:35 ` Josh Poimboeuf
2017-05-20 5:23 ` Andy Lutomirski
2017-05-20 16:20 ` Josh Poimboeuf
2017-05-20 17:19 ` Josh Poimboeuf
2017-05-20 20:01 ` H.J. Lu
2017-05-20 21:58 ` Andy Lutomirski
2017-05-20 22:20 ` H.J. Lu
2017-05-22 11:34 ` Jiri Kosina
2017-05-22 14:39 ` H.J. Lu
2017-05-22 21:07 ` H. Peter Anvin
2017-05-22 21:37 ` H. Peter Anvin
2017-05-22 22:11 ` Josh Poimboeuf [this message]
2017-05-20 20:16 ` Linus Torvalds
2017-05-20 21:56 ` Andy Lutomirski
2017-05-20 23:00 ` Linus Torvalds
2017-05-20 23:29 ` Linus Torvalds
2017-05-26 6:54 ` Jiri Slaby
2017-05-26 11:29 ` Jiri Slaby
2017-05-26 12:14 ` Josh Poimboeuf
2017-05-22 11:12 ` Ingo Molnar
2017-05-22 21:16 ` H. Peter Anvin
2017-05-22 23:23 ` Jiri Kosina
2017-05-23 5:49 ` Ingo Molnar
2017-05-26 19:16 ` hpa
2017-05-28 9:12 ` Ingo Molnar
2017-05-10 7:39 ` Jiri Slaby
2017-05-10 12:42 ` Josh Poimboeuf
2017-05-10 12:47 ` Jiri Slaby
2017-05-10 18:11 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170522221116.onntuq7rinnqudcw@treble \
--to=jpoimboe@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hjl.tools@gmail.com \
--cc=hpa@zytor.com \
--cc=jikos@kernel.org \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®