From: Mark Brown <broonie@kernel.org>
To: Ryan Lee <ryans.lee@maximintegrated.com>
Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
ryan.lee.maxim@gmail.com
Subject: Re: [PATCH] ASoC: max98927: Adding support for TDM mode and Envelop tracking control
Date: Sun, 14 May 2017 19:11:15 +0900 [thread overview]
Message-ID: <20170514101115.f53hlcbp7z4muelu@sirena.org.uk> (raw)
In-Reply-To: <1494006135-1178-1-git-send-email-ryans.lee@maximintegrated.com>
[-- Attachment #1: Type: text/plain, Size: 655 bytes --]
On Fri, May 05, 2017 at 10:42:15AM -0700, Ryan Lee wrote:
> Signed-off-by: Ryan Lee <ryans.lee@maximintegrated.com>
> ---
The subject line suggests that this is adding two new features. Unless
they are very closely related in the code they should be submitted as
separate patches as covered in SubmittingPatches.
> default:
> - dev_err(codec->dev, "DAI clock mode unsupported");
> + dev_err(codec->dev, "DAI clock mode unsupported\n");
> return -EINVAL;
> }
>
It also seems like there are a number of unrelated stylistic changes in
this patch. While it's fine to make such changes they too should be in
separate patches.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2017-05-15 7:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-05 17:42 Ryan Lee
2017-05-14 10:11 ` Mark Brown [this message]
2017-05-19 3:12 ` Ryan Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170514101115.f53hlcbp7z4muelu@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=ryan.lee.maxim@gmail.com \
--cc=ryans.lee@maximintegrated.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®