From: Mark Brown <broonie@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Vignesh R <vigneshr@ti.com>,
linux-spi <linux-spi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] spi: SPI_TI_QSPI should depend on HAS_DMA
Date: Mon, 15 May 2017 11:53:19 +0100 [thread overview]
Message-ID: <20170515105319.5vm46modegh3gfke@sirena.org.uk> (raw)
In-Reply-To: <CAMuHMdUs31Bq5SU5uMcmoRtPd7zpop18XYRF9mAOzJ8e62JHaQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 757 bytes --]
On Mon, May 15, 2017 at 12:21:33PM +0200, Geert Uytterhoeven wrote:
> On Mon, May 15, 2017 at 12:12 PM, Mark Brown <broonie@kernel.org> wrote:
> > No, I was thinking more just not needing the dependency at all.
> Then what's the point of the existence of COMPILE_TEST?
> We can just have stubs for everything, and always build everything.
It's useful for platform specific devices (like this one should be) but
having to add dependencies for basic kernel APIs like the DMA one is
just making for a lot of noise. There's plenty of platforms without DMA
that also have no real use for this driver, it's not really a relevant
thing when deciding if the driver might be useful if what you're trying
to do is hide drivers that aren't useful on the platform.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2017-05-15 10:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-04 7:37 Geert Uytterhoeven
2017-05-14 9:50 ` Mark Brown
2017-05-15 8:46 ` Geert Uytterhoeven
2017-05-15 10:12 ` Mark Brown
2017-05-15 10:21 ` Geert Uytterhoeven
2017-05-15 10:53 ` Mark Brown [this message]
2017-05-15 8:04 ` Applied "spi: SPI_TI_QSPI should depend on HAS_DMA" to the spi tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170515105319.5vm46modegh3gfke@sirena.org.uk \
--to=broonie@kernel.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®