From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Oliver Hartkopp <socketcan@hartkopp.net>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>,
Quentin Schulz <quentin.schulz@free-electrons.com>,
wg@grandegger.com, mario.huettel@gmx.net,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
thomas.petazzoni@free-electrons.com
Subject: Re: [PATCH v4 1/4] can: m_can: move Message RAM initialization to function
Date: Tue, 16 May 2017 10:00:49 +0200 [thread overview]
Message-ID: <20170516080049.4fvo4hkj4e6v7r3v@piout.net> (raw)
In-Reply-To: <1d41efe1-d24f-4700-8986-0d5dc848ea23@hartkopp.net>
Hi,
On 15/05/2017 at 20:51:30 -0700, Oliver Hartkopp wrote:
> On 05/15/2017 06:50 AM, Marc Kleine-Budde wrote:
> > On 05/12/2017 08:37 AM, Quentin Schulz wrote:
> > > On 05/05/2017 15:50, Quentin Schulz wrote:
> > > > To avoid possible ECC/parity checksum errors when reading an
> > > > uninitialized buffer, the entire Message RAM is initialized when probing
> > > > the driver. This initialization is done in the same function reading the
> > > > Device Tree properties.
> > > >
> > > > This patch moves the RAM initialization to a separate function so it can
> > > > be called separately from device initialization from Device Tree.
> > > >
> > > > Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com>
> > >
> > > It's been a week since I sent this patch series. Any comments?
> >
> > Looks good, added to linux-can-next.
>
> Isn't this a fix for linux-can instead?
>
> At least it would make no sense to me to have the upgraded M_CAN driver in
> Linux 4.12 without this fix.
>
The related suspend mode on the sama5d2 is not present in v4.12 so I
think this can wait v4.13.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-05-16 8:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-05 13:50 Quentin Schulz
2017-05-05 13:50 ` [PATCH v4 2/4] can: m_can: make m_can_start and m_can_stop symmetric Quentin Schulz
2017-05-05 13:50 ` [PATCH v4 3/4] can: m_can: factorize clock gating and ungating Quentin Schulz
2017-05-05 13:50 ` [PATCH v4 4/4] can: m_can: add deep Suspend/Resume support Quentin Schulz
2017-05-12 6:37 ` [PATCH v4 1/4] can: m_can: move Message RAM initialization to function Quentin Schulz
2017-05-15 13:50 ` Marc Kleine-Budde
2017-05-16 3:51 ` Oliver Hartkopp
2017-05-16 8:00 ` Alexandre Belloni [this message]
2017-05-16 13:16 ` Oliver Hartkopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170516080049.4fvo4hkj4e6v7r3v@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.huettel@gmx.net \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=quentin.schulz@free-electrons.com \
--cc=socketcan@hartkopp.net \
--cc=thomas.petazzoni@free-electrons.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®