From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Marc Kleine-Budde <mkl@pengutronix.de>,
Quentin Schulz <quentin.schulz@free-electrons.com>,
wg@grandegger.com, mario.huettel@gmx.net
Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
alexandre.belloni@free-electrons.com,
thomas.petazzoni@free-electrons.com
Subject: Re: [PATCH v4 1/4] can: m_can: move Message RAM initialization to function
Date: Mon, 15 May 2017 20:51:30 -0700 [thread overview]
Message-ID: <1d41efe1-d24f-4700-8986-0d5dc848ea23@hartkopp.net> (raw)
In-Reply-To: <4676456c-823c-d7db-2139-35c8229109f0@pengutronix.de>
On 05/15/2017 06:50 AM, Marc Kleine-Budde wrote:
> On 05/12/2017 08:37 AM, Quentin Schulz wrote:
>> Hi all,
>>
>> On 05/05/2017 15:50, Quentin Schulz wrote:
>>> To avoid possible ECC/parity checksum errors when reading an
>>> uninitialized buffer, the entire Message RAM is initialized when probing
>>> the driver. This initialization is done in the same function reading the
>>> Device Tree properties.
>>>
>>> This patch moves the RAM initialization to a separate function so it can
>>> be called separately from device initialization from Device Tree.
>>>
>>> Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com>
>>
>> It's been a week since I sent this patch series. Any comments?
>
> Looks good, added to linux-can-next.
Isn't this a fix for linux-can instead?
At least it would make no sense to me to have the upgraded M_CAN driver
in Linux 4.12 without this fix.
Regards,
Oliver
next prev parent reply other threads:[~2017-05-16 3:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-05 13:50 Quentin Schulz
2017-05-05 13:50 ` [PATCH v4 2/4] can: m_can: make m_can_start and m_can_stop symmetric Quentin Schulz
2017-05-05 13:50 ` [PATCH v4 3/4] can: m_can: factorize clock gating and ungating Quentin Schulz
2017-05-05 13:50 ` [PATCH v4 4/4] can: m_can: add deep Suspend/Resume support Quentin Schulz
2017-05-12 6:37 ` [PATCH v4 1/4] can: m_can: move Message RAM initialization to function Quentin Schulz
2017-05-15 13:50 ` Marc Kleine-Budde
2017-05-16 3:51 ` Oliver Hartkopp [this message]
2017-05-16 8:00 ` Alexandre Belloni
2017-05-16 13:16 ` Oliver Hartkopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d41efe1-d24f-4700-8986-0d5dc848ea23@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=alexandre.belloni@free-electrons.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.huettel@gmx.net \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=quentin.schulz@free-electrons.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®