* [PATCH] staging: fsl-dpaa2/eth: add ETHERNET dependency
@ 2017-05-16 11:30 Arnd Bergmann
2017-05-17 12:42 ` Ruxandra Ioana Radulescu
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2017-05-16 11:30 UTC (permalink / raw)
To: Greg Kroah-Hartman, Arnd Bergmann; +Cc: Ioana Radulescu, devel, linux-kernel
The new driver cannot link correctly when the netdevice infrastructure
is disabled:
ERROR: "netdev_info" [drivers/staging/fsl-dpaa2/ethernet/fsl-dpaa2-eth.ko] undefined!
ERROR: "skb_to_sgvec" [drivers/staging/fsl-dpaa2/ethernet/fsl-dpaa2-eth.ko] undefined!
ERROR: "napi_disable" [drivers/staging/fsl-dpaa2/ethernet/fsl-dpaa2-eth.ko] undefined!
ERROR: "napi_schedule_prep" [drivers/staging/fsl-dpaa2/ethernet/fsl-dpaa2-eth.ko] undefined!
ERROR: "__napi_schedule_irqoff" [drivers/staging/fsl-dpaa2/ethernet/fsl-dpaa2-eth.ko] undefined!
ERROR: "netif_carrier_on" [drivers/staging/fsl-dpaa2/ethernet/fsl-dpaa2-eth.ko] undefined!
This adds a dependency on NETDEVICES and ETHERNET.
Fixes: 0352d1d85201 ("staging: fsl-dpaa2/eth: Add APIs for DPNI objects")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/staging/fsl-dpaa2/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/fsl-dpaa2/Kconfig b/drivers/staging/fsl-dpaa2/Kconfig
index 2e325cb747ae..730fd6d4db33 100644
--- a/drivers/staging/fsl-dpaa2/Kconfig
+++ b/drivers/staging/fsl-dpaa2/Kconfig
@@ -12,6 +12,7 @@ config FSL_DPAA2
config FSL_DPAA2_ETH
tristate "Freescale DPAA2 Ethernet"
depends on FSL_DPAA2 && FSL_MC_DPIO
+ depends on NETDEVICES && ETHERNET
---help---
Ethernet driver for Freescale DPAA2 SoCs, using the
Freescale MC bus driver
--
2.9.0
^ permalink raw reply [flat|nested] 2+ messages in thread* RE: [PATCH] staging: fsl-dpaa2/eth: add ETHERNET dependency
2017-05-16 11:30 [PATCH] staging: fsl-dpaa2/eth: add ETHERNET dependency Arnd Bergmann
@ 2017-05-17 12:42 ` Ruxandra Ioana Radulescu
0 siblings, 0 replies; 2+ messages in thread
From: Ruxandra Ioana Radulescu @ 2017-05-17 12:42 UTC (permalink / raw)
To: Arnd Bergmann, Greg Kroah-Hartman; +Cc: devel, linux-kernel
> -----Original Message-----
> From: Arnd Bergmann [mailto:arnd@arndb.de]
> Sent: Tuesday, May 16, 2017 2:30 PM
> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Arnd Bergmann
> <arnd@arndb.de>
> Cc: Ruxandra Ioana Radulescu <ruxandra.radulescu@nxp.com>;
> devel@driverdev.osuosl.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] staging: fsl-dpaa2/eth: add ETHERNET dependency
>
> The new driver cannot link correctly when the netdevice infrastructure
> is disabled:
>
> ERROR: "netdev_info" [drivers/staging/fsl-dpaa2/ethernet/fsl-dpaa2-eth.ko]
> undefined!
> ERROR: "skb_to_sgvec" [drivers/staging/fsl-dpaa2/ethernet/fsl-dpaa2-
> eth.ko] undefined!
> ERROR: "napi_disable" [drivers/staging/fsl-dpaa2/ethernet/fsl-dpaa2-
> eth.ko] undefined!
> ERROR: "napi_schedule_prep" [drivers/staging/fsl-dpaa2/ethernet/fsl-
> dpaa2-eth.ko] undefined!
> ERROR: "__napi_schedule_irqoff" [drivers/staging/fsl-dpaa2/ethernet/fsl-
> dpaa2-eth.ko] undefined!
> ERROR: "netif_carrier_on" [drivers/staging/fsl-dpaa2/ethernet/fsl-dpaa2-
> eth.ko] undefined!
>
> This adds a dependency on NETDEVICES and ETHERNET.
>
> Fixes: 0352d1d85201 ("staging: fsl-dpaa2/eth: Add APIs for DPNI objects")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/staging/fsl-dpaa2/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/fsl-dpaa2/Kconfig b/drivers/staging/fsl-
> dpaa2/Kconfig
> index 2e325cb747ae..730fd6d4db33 100644
> --- a/drivers/staging/fsl-dpaa2/Kconfig
> +++ b/drivers/staging/fsl-dpaa2/Kconfig
> @@ -12,6 +12,7 @@ config FSL_DPAA2
> config FSL_DPAA2_ETH
> tristate "Freescale DPAA2 Ethernet"
> depends on FSL_DPAA2 && FSL_MC_DPIO
> + depends on NETDEVICES && ETHERNET
> ---help---
> Ethernet driver for Freescale DPAA2 SoCs, using the
> Freescale MC bus driver
> --
> 2.9.0
Thanks!
Acked-by: Ioana Radulescu <ruxandra.radulescu@nxp.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-05-17 12:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-16 11:30 [PATCH] staging: fsl-dpaa2/eth: add ETHERNET dependency Arnd Bergmann
2017-05-17 12:42 ` Ruxandra Ioana Radulescu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®