From: kbuild test robot <lkp@intel.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>, Oleg Nesterov <oleg@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 8/8] waitid(): switch copyout of siginfo to unsafe_put_user()
Date: Tue, 16 May 2017 11:55:38 +0800 [thread overview]
Message-ID: <201705161156.ugSNWX8g%fengguang.wu@intel.com> (raw)
In-Reply-To: <20170515223716.2085-8-viro@ZenIV.linux.org.uk>
[-- Attachment #1: Type: text/plain, Size: 6392 bytes --]
Hi Al,
[auto build test WARNING on linus/master]
[also build test WARNING on v4.12-rc1 next-20170515]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Al-Viro/move-compat-wait4-and-waitid-next-to-native-variants/20170516-084127
config: powerpc-allmodconfig (attached as .config)
compiler: powerpc64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=powerpc
All warnings (new ones prefixed by >>):
In file included from include/asm-generic/bug.h:4:0,
from arch/powerpc/include/asm/bug.h:127,
from include/linux/bug.h:4,
from include/linux/mmdebug.h:4,
from include/linux/mm.h:8,
from kernel/exit.c:7:
kernel/exit.c: In function 'C_SYSC_waitid':
kernel/exit.c:1746:38: error: 'infop' undeclared (first use in this function)
unsafe_put_user(err ? 0 : SIGCHLD, &infop->si_signo, Efault);
^
include/linux/compiler.h:179:42: note: in definition of macro 'unlikely'
# define unlikely(x) __builtin_expect(!!(x), 0)
^
>> arch/powerpc/include/asm/uaccess.h:86:2: note: in expansion of macro '__put_user_nocheck'
__put_user_nocheck((__typeof__(*(ptr)))(x), (ptr), sizeof(*(ptr)))
^~~~~~~~~~~~~~~~~~
include/linux/uaccess.h:302:56: note: in expansion of macro '__put_user'
#define unsafe_put_user(x, ptr, err) do { if (unlikely(__put_user(x, ptr))) goto err; } while (0)
^~~~~~~~~~
kernel/exit.c:1746:2: note: in expansion of macro 'unsafe_put_user'
unsafe_put_user(err ? 0 : SIGCHLD, &infop->si_signo, Efault);
^~~~~~~~~~~~~~~
kernel/exit.c:1746:38: note: each undeclared identifier is reported only once for each function it appears in
unsafe_put_user(err ? 0 : SIGCHLD, &infop->si_signo, Efault);
^
include/linux/compiler.h:179:42: note: in definition of macro 'unlikely'
# define unlikely(x) __builtin_expect(!!(x), 0)
^
>> arch/powerpc/include/asm/uaccess.h:86:2: note: in expansion of macro '__put_user_nocheck'
__put_user_nocheck((__typeof__(*(ptr)))(x), (ptr), sizeof(*(ptr)))
^~~~~~~~~~~~~~~~~~
include/linux/uaccess.h:302:56: note: in expansion of macro '__put_user'
#define unsafe_put_user(x, ptr, err) do { if (unlikely(__put_user(x, ptr))) goto err; } while (0)
^~~~~~~~~~
kernel/exit.c:1746:2: note: in expansion of macro 'unsafe_put_user'
unsafe_put_user(err ? 0 : SIGCHLD, &infop->si_signo, Efault);
^~~~~~~~~~~~~~~
vim +/__put_user_nocheck +86 arch/powerpc/include/asm/uaccess.h
2df5e8bc include/asm-powerpc/uaccess.h Stephen Rothwell 2005-10-29 70 * with a separate "access_ok()" call (this is used when we do multiple
2df5e8bc include/asm-powerpc/uaccess.h Stephen Rothwell 2005-10-29 71 * accesses to the same area of user memory).
2df5e8bc include/asm-powerpc/uaccess.h Stephen Rothwell 2005-10-29 72 *
2df5e8bc include/asm-powerpc/uaccess.h Stephen Rothwell 2005-10-29 73 * As we use the same address space for kernel and user data on the
2df5e8bc include/asm-powerpc/uaccess.h Stephen Rothwell 2005-10-29 74 * PowerPC, we can just do these as direct assignments. (Of course, the
2df5e8bc include/asm-powerpc/uaccess.h Stephen Rothwell 2005-10-29 75 * exception handling means that it's no longer "just"...)
2df5e8bc include/asm-powerpc/uaccess.h Stephen Rothwell 2005-10-29 76 *
2df5e8bc include/asm-powerpc/uaccess.h Stephen Rothwell 2005-10-29 77 */
2df5e8bc include/asm-powerpc/uaccess.h Stephen Rothwell 2005-10-29 78 #define get_user(x, ptr) \
2df5e8bc include/asm-powerpc/uaccess.h Stephen Rothwell 2005-10-29 79 __get_user_check((x), (ptr), sizeof(*(ptr)))
2df5e8bc include/asm-powerpc/uaccess.h Stephen Rothwell 2005-10-29 80 #define put_user(x, ptr) \
2df5e8bc include/asm-powerpc/uaccess.h Stephen Rothwell 2005-10-29 81 __put_user_check((__typeof__(*(ptr)))(x), (ptr), sizeof(*(ptr)))
2df5e8bc include/asm-powerpc/uaccess.h Stephen Rothwell 2005-10-29 82
2df5e8bc include/asm-powerpc/uaccess.h Stephen Rothwell 2005-10-29 83 #define __get_user(x, ptr) \
2df5e8bc include/asm-powerpc/uaccess.h Stephen Rothwell 2005-10-29 84 __get_user_nocheck((x), (ptr), sizeof(*(ptr)))
2df5e8bc include/asm-powerpc/uaccess.h Stephen Rothwell 2005-10-29 85 #define __put_user(x, ptr) \
2df5e8bc include/asm-powerpc/uaccess.h Stephen Rothwell 2005-10-29 @86 __put_user_nocheck((__typeof__(*(ptr)))(x), (ptr), sizeof(*(ptr)))
e68c825b include/asm-powerpc/uaccess.h Benjamin Herrenschmidt 2007-04-11 87
e68c825b include/asm-powerpc/uaccess.h Benjamin Herrenschmidt 2007-04-11 88 #define __get_user_inatomic(x, ptr) \
e68c825b include/asm-powerpc/uaccess.h Benjamin Herrenschmidt 2007-04-11 89 __get_user_nosleep((x), (ptr), sizeof(*(ptr)))
e68c825b include/asm-powerpc/uaccess.h Benjamin Herrenschmidt 2007-04-11 90 #define __put_user_inatomic(x, ptr) \
e68c825b include/asm-powerpc/uaccess.h Benjamin Herrenschmidt 2007-04-11 91 __put_user_nosleep((__typeof__(*(ptr)))(x), (ptr), sizeof(*(ptr)))
e68c825b include/asm-powerpc/uaccess.h Benjamin Herrenschmidt 2007-04-11 92
2df5e8bc include/asm-powerpc/uaccess.h Stephen Rothwell 2005-10-29 93 #define __get_user_unaligned __get_user
2df5e8bc include/asm-powerpc/uaccess.h Stephen Rothwell 2005-10-29 94 #define __put_user_unaligned __put_user
:::::: The code at line 86 was first introduced by commit
:::::: 2df5e8bcca53e528a78ee0e3b114d0d21dd6d043 powerpc: merge uaccess.h
:::::: TO: Stephen Rothwell <sfr@canb.auug.org.au>
:::::: CC: Stephen Rothwell <sfr@canb.auug.org.au>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 53757 bytes --]
next prev parent reply other threads:[~2017-05-16 3:56 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-15 22:31 [RFC][PATCHSET] wait4()/waitid() cleanups Al Viro
2017-05-15 22:37 ` [PATCH 1/8] move compat wait4 and waitid next to native variants Al Viro
2017-05-15 22:37 ` [PATCH 2/8] wait4(2)/waitid(2): separate copying rusage to userland Al Viro
2017-05-15 22:37 ` [PATCH 3/8] kernel_wait4()/kernel_waitid(): delay copying status " Al Viro
2017-05-15 22:37 ` [PATCH 4/8] waitid(2): leave copyout of siginfo to syscall itself Al Viro
2017-05-15 23:06 ` Linus Torvalds
2017-05-15 23:46 ` Al Viro
2017-05-17 19:48 ` Eric W. Biederman
2017-05-15 22:37 ` [PATCH 5/8] lift getrusage() from wait_noreap_copyout() Al Viro
2017-05-15 22:37 ` [PATCH 6/8] kill wait_noreap_copyout() Al Viro
2017-05-15 22:37 ` [PATCH 7/8] wait_task_zombie: consolidate info logics Al Viro
2017-05-15 22:37 ` [PATCH 8/8] waitid(): switch copyout of siginfo to unsafe_put_user() Al Viro
2017-05-16 3:55 ` kbuild test robot [this message]
2017-05-16 4:17 ` kbuild test robot
2017-05-19 6:08 ` [lkp-robot] [waitid()] 75f64d68f9: Kernel_panic-not_syncing:Attempted_to_kill_init!exitcode= kernel test robot
2017-05-21 7:34 ` Al Viro
2017-05-21 19:04 ` Linus Torvalds
2017-05-21 19:35 ` Linus Torvalds
2017-05-21 21:14 ` Al Viro
2017-05-21 21:37 ` Linus Torvalds
2017-05-21 22:19 ` Linus Torvalds
2017-05-22 1:39 ` Linus Torvalds
2017-05-17 19:57 ` [RFC][PATCHSET] wait4()/waitid() cleanups Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201705161156.ugSNWX8g%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=hch@lst.de \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®