From: Linus Torvalds <torvalds@linux-foundation.org>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: kernel test robot <xiaolong.ye@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>, Oleg Nesterov <oleg@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Christoph Hellwig <hch@lst.de>, LKP <lkp@01.org>
Subject: Re: [lkp-robot] [waitid()] 75f64d68f9: Kernel_panic-not_syncing:Attempted_to_kill_init!exitcode=
Date: Sun, 21 May 2017 12:04:38 -0700 [thread overview]
Message-ID: <CA+55aFzDP03pKyhFtpLE1jTJESP2usOPsu562aQ3jyY7aRFtGA@mail.gmail.com> (raw)
In-Reply-To: <20170521073405.GX390@ZenIV.linux.org.uk>
On Sun, May 21, 2017 at 12:34 AM, Al Viro <viro@zeniv.linux.org.uk> wrote:
>
> - __put_user_size((x), (ptr), sizeof(*(ptr)), __pu_err, -EFAULT); \
> + __put_user_size((__typeof__(*(ptr)))(x), (ptr), sizeof(*(ptr)), __pu_err, -EFAULT); \
Hmm. Looking more at this, the "unsafe_get_user()" case is wrong too -
for types larger than "long".
But I see you have a pull request pending, and I'll take this fix as-is.
I *think* the right thing to do is to just do
register __inttype(*(ptr)) __val_gu;
for unsafe_get_user.
I think the error crept in because I copied the "get_user_ex()" code,
which has the same type confusion (ie it doesn't handle values larger
then long, so "long long" on x86-32 wouldn't work).
That type limitation was ok'ish simply because get_user_ex() was
x86-only and of very limited use (and clearly never saw the 64-bit
value on a 32-bit arch case).
But for unsafe_get_user() we obviously want to make it generic enough
and just be able to replace existing get_user() calls.
Linus
next prev parent reply other threads:[~2017-05-21 19:04 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-15 22:31 [RFC][PATCHSET] wait4()/waitid() cleanups Al Viro
2017-05-15 22:37 ` [PATCH 1/8] move compat wait4 and waitid next to native variants Al Viro
2017-05-15 22:37 ` [PATCH 2/8] wait4(2)/waitid(2): separate copying rusage to userland Al Viro
2017-05-15 22:37 ` [PATCH 3/8] kernel_wait4()/kernel_waitid(): delay copying status " Al Viro
2017-05-15 22:37 ` [PATCH 4/8] waitid(2): leave copyout of siginfo to syscall itself Al Viro
2017-05-15 23:06 ` Linus Torvalds
2017-05-15 23:46 ` Al Viro
2017-05-17 19:48 ` Eric W. Biederman
2017-05-15 22:37 ` [PATCH 5/8] lift getrusage() from wait_noreap_copyout() Al Viro
2017-05-15 22:37 ` [PATCH 6/8] kill wait_noreap_copyout() Al Viro
2017-05-15 22:37 ` [PATCH 7/8] wait_task_zombie: consolidate info logics Al Viro
2017-05-15 22:37 ` [PATCH 8/8] waitid(): switch copyout of siginfo to unsafe_put_user() Al Viro
2017-05-16 3:55 ` kbuild test robot
2017-05-16 4:17 ` kbuild test robot
2017-05-19 6:08 ` [lkp-robot] [waitid()] 75f64d68f9: Kernel_panic-not_syncing:Attempted_to_kill_init!exitcode= kernel test robot
2017-05-21 7:34 ` Al Viro
2017-05-21 19:04 ` Linus Torvalds [this message]
2017-05-21 19:35 ` Linus Torvalds
2017-05-21 21:14 ` Al Viro
2017-05-21 21:37 ` Linus Torvalds
2017-05-21 22:19 ` Linus Torvalds
2017-05-22 1:39 ` Linus Torvalds
2017-05-17 19:57 ` [RFC][PATCHSET] wait4()/waitid() cleanups Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+55aFzDP03pKyhFtpLE1jTJESP2usOPsu562aQ3jyY7aRFtGA@mail.gmail.com \
--to=torvalds@linux-foundation.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@01.org \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=viro@zeniv.linux.org.uk \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®