From: Mark Brown <broonie@kernel.org>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: linux-spi@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/2] spidev: Adjust five checks for null pointers
Date: Thu, 18 May 2017 12:28:46 +0100 [thread overview]
Message-ID: <20170518112846.tcirhguyps3kk3ra@sirena.org.uk> (raw)
In-Reply-To: <df3e58c6-f70d-a5d3-102e-4fab2f7df126@users.sourceforge.net>
[-- Attachment #1: Type: text/plain, Size: 652 bytes --]
On Wed, May 17, 2017 at 05:47:29PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Wed, 17 May 2017 17:30:28 +0200
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
Please fix however you're sending things out to avoid this noise.
> The script “checkpatch.pl” pointed information out like the following.
>
> Comparison to NULL could be written !…
>
> Thus fix the affected source code places.
This changelog does not describe any purpose in making this change, we
could equally well say the exact opposite. Why should we do this?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2017-05-18 11:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-17 15:43 [PATCH 0/2] spidev: Adjustments for six function implementations SF Markus Elfring
2017-05-17 15:45 ` [PATCH 1/2] spidev: Delete error messages for failed memory allocations in spidev_open() SF Markus Elfring
2017-05-17 15:47 ` [PATCH 2/2] spidev: Adjust five checks for null pointers SF Markus Elfring
2017-05-18 11:28 ` Mark Brown [this message]
2017-05-18 14:34 ` SF Markus Elfring
2017-05-22 12:33 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170518112846.tcirhguyps3kk3ra@sirena.org.uk \
--to=broonie@kernel.org \
--cc=elfring@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®