* [PATCH -next] drm/i915: Fix return value check in kfence selftests
@ 2017-05-19 0:26 Wei Yongjun
2017-05-19 7:41 ` Chris Wilson
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2017-05-19 0:26 UTC (permalink / raw)
To: Daniel Vetter, Jani Nikula, David Airlie, Mika Kuoppala, Chris Wilson
Cc: Wei Yongjun, intel-gfx, dri-devel, linux-kernel
From: Wei Yongjun <weiyongjun1@huawei.com>
Fix the return value check which testing the wrong variable.
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/gpu/drm/i915/selftests/i915_sw_fence.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/selftests/i915_sw_fence.c b/drivers/gpu/drm/i915/selftests/i915_sw_fence.c
index 98baf10..c31d439 100644
--- a/drivers/gpu/drm/i915/selftests/i915_sw_fence.c
+++ b/drivers/gpu/drm/i915/selftests/i915_sw_fence.c
@@ -311,7 +311,7 @@ static int test_AB_C(void *arg)
}
C = alloc_fence();
- if (!B) {
+ if (!C) {
ret = -ENOMEM;
goto err_B;
}
@@ -388,7 +388,7 @@ static int test_C_AB(void *arg)
}
C = alloc_fence();
- if (!B) {
+ if (!C) {
ret = -ENOMEM;
goto err_B;
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH -next] drm/i915: Fix return value check in kfence selftests
2017-05-19 0:26 [PATCH -next] drm/i915: Fix return value check in kfence selftests Wei Yongjun
@ 2017-05-19 7:41 ` Chris Wilson
0 siblings, 0 replies; 2+ messages in thread
From: Chris Wilson @ 2017-05-19 7:41 UTC (permalink / raw)
To: Wei Yongjun
Cc: Daniel Vetter, Jani Nikula, David Airlie, Mika Kuoppala,
Wei Yongjun, intel-gfx, dri-devel, linux-kernel
On Fri, May 19, 2017 at 12:26:05AM +0000, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fix the return value check which testing the wrong variable.
Already fixed up yesterday:
commit ac0a73fb526100adc521ec2069623e47ca3997a8
Author: Colin Ian King <colin.king@canonical.com>
Date: Thu May 18 14:39:42 2017 +0100
drm/i915: Check C for null pointer rather than B
Thanks for the patch.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-05-19 7:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-19 0:26 [PATCH -next] drm/i915: Fix return value check in kfence selftests Wei Yongjun
2017-05-19 7:41 ` Chris Wilson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®