mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Viresh Kumar <viresh.kumar@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Vaibhav Hiremath <hvaibhav.linux@gmail.com>,
	Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	devel@driverdev.osuosl.org, greybus-dev@lists.linaro.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [greybus-dev] [PATCH] staging: greybus: mark PM functions as __maybe_unused
Date: Fri, 19 May 2017 09:10:07 +0530	[thread overview]
Message-ID: <20170519034007.GJ17481@vireshk-i7> (raw)
In-Reply-To: <CAK8P3a2c_Q9gzmFqJmPkiz780M5s6+yN+q+3-PaOrYVz=Utc-Q@mail.gmail.com>

On 18-05-17, 16:51, Arnd Bergmann wrote:
> I find that a lot of users get the #ifdef wrong, either using the wrong
> macro (CONFIG_PM vs CONFIG_PM_SLEEP) or not using the right
> set of functions (e.g. calling a function only from the suspend handler).
> 
> The __maybe_unused annotation avoids both problems and also gives
> better build time coverage, so that's what I tend to use.

Thanks for the explanation Arnd. I hope these unused routines will not
be part of the binary that gets generated. Right?

Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh

  reply	other threads:[~2017-05-19  3:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-18 13:28 Arnd Bergmann
2017-05-18 13:33 ` Johan Hovold
2017-05-18 14:18 ` [greybus-dev] " Viresh Kumar
2017-05-18 14:51   ` Arnd Bergmann
2017-05-19  3:40     ` Viresh Kumar [this message]
2017-05-19  6:57       ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170519034007.GJ17481@vireshk-i7 \
    --to=viresh.kumar@linaro.org \
    --cc=arnd@arndb.de \
    --cc=devel@driverdev.osuosl.org \
    --cc=elder@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=greybus-dev@lists.linaro.org \
    --cc=hvaibhav.linux@gmail.com \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®