* [PATCH] usb: chipidea: core: check before accessing ci_role in ci_role_show
@ 2017-05-19 8:32 Michael Thalmeier
0 siblings, 0 replies; only message in thread
From: Michael Thalmeier @ 2017-05-19 8:32 UTC (permalink / raw)
To: Peter Chen, Greg Kroah-Hartman; +Cc: linux-usb, linux-kernel, michael
ci_role BUGs when the role is >= CI_ROLE_END.
This is the case while the role is changing.
Signed-off-by: Michael Thalmeier <michael.thalmeier@hale.at>
---
drivers/usb/chipidea/core.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
index 9e217b1..fe4fe24 100644
--- a/drivers/usb/chipidea/core.c
+++ b/drivers/usb/chipidea/core.c
@@ -843,7 +843,10 @@ static ssize_t ci_role_show(struct device *dev, struct device_attribute *attr,
{
struct ci_hdrc *ci = dev_get_drvdata(dev);
- return sprintf(buf, "%s\n", ci_role(ci)->name);
+ if (ci->role != CI_ROLE_END)
+ return sprintf(buf, "%s\n", ci_role(ci)->name);
+
+ return 0;
}
static ssize_t ci_role_store(struct device *dev,
--
2.9.2
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2017-05-19 8:33 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-19 8:32 [PATCH] usb: chipidea: core: check before accessing ci_role in ci_role_show Michael Thalmeier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®