From: Peter Zijlstra <peterz@infradead.org>
To: "Jin, Yao" <yao.jin@linux.intel.com>
Cc: acme@kernel.org, jolsa@kernel.org, mingo@redhat.com,
alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org,
ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com,
Will Deacon <will.deacon@arm.com>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH] perf/x86/intel: Drop kernel samples even though :u is specified
Date: Fri, 19 May 2017 14:36:48 +0200 [thread overview]
Message-ID: <20170519123648.p4tkt6xrt5xachuw@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <ae456a2e-a4c9-7cda-ab50-6135c53fe321@linux.intel.com>
On Fri, May 19, 2017 at 08:24:19PM +0800, Jin, Yao wrote:
> > Ah, I was more thinking of something like PERF_PMU_CAP_NO_SKID or
> > something that would skip the test and preserve current behaviour.
>
> OK, I understand now. For example, for PEBS event, its capabilities should
> be set with PERF_PMU_CAP_NO_SKID.
Except you cannot in fact do that, since PEBS is the same struct pmu as
the normal counters (they share counter space after all).
Also, weren't there PEBS errata that would allow this to happen?
But no, more for other architectures to opt out for some reason. But I'm
thinking we want to start out by unconditionally doing this. It would be
good to try and Cc most arch pmu maintainers on this though, so they can
object.
next prev parent reply other threads:[~2017-05-19 12:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-19 10:19 Jin Yao
2017-05-19 9:29 ` Peter Zijlstra
2017-05-19 9:42 ` Will Deacon
2017-05-19 12:06 ` Jin, Yao
2017-05-19 12:10 ` Peter Zijlstra
2017-05-19 12:24 ` Jin, Yao
2017-05-19 12:36 ` Peter Zijlstra [this message]
2017-05-19 13:33 ` Jin, Yao
2017-05-22 2:12 ` Jin, Yao
2017-05-22 8:45 ` Mark Rutland
2017-05-22 9:26 ` Peter Zijlstra
2017-05-22 12:30 ` Jin, Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170519123648.p4tkt6xrt5xachuw@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=will.deacon@arm.com \
--cc=yao.jin@intel.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®