From: "Jin, Yao" <yao.jin@linux.intel.com>
To: Peter Zijlstra <peterz@infradead.org>,
Mark Rutland <mark.rutland@arm.com>
Cc: acme@kernel.org, jolsa@kernel.org, mingo@redhat.com,
alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org,
ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com,
Will Deacon <will.deacon@arm.com>
Subject: Re: [PATCH] perf/x86/intel: Drop kernel samples even though :u is specified
Date: Mon, 22 May 2017 20:30:54 +0800 [thread overview]
Message-ID: <94a086e2-af12-49e9-f9c7-5b4b1b83ddfb@linux.intel.com> (raw)
In-Reply-To: <20170522092651.nwhlpdws2ysyhlma@hirez.programming.kicks-ass.net>
On 5/22/2017 5:26 PM, Peter Zijlstra wrote:
> On Mon, May 22, 2017 at 09:45:30AM +0100, Mark Rutland wrote:
>> On Mon, May 22, 2017 at 10:12:22AM +0800, Jin, Yao wrote:
>>> But the code is being ugly and hard to maintain. And frankly I don't
>>> know kernel address space for all arch.
>>>
>>> Any idea? Could we just do at x86 side this time?
>> Can we not check user_mode(regs) for all architectures?
>>
>> !user_mode(regs) implies a kernel sample.
> Yes, that should work at that point. We specifically already rely on
> user_mode() in the generic code.
>
> On x86 we specifically set regs->cs to match regs->ip (in cases where
> this isn't necessarily so) before calling into the generic code to make
> this work.
>
Got it.
Thanks Mark, thanks Peter!
prev parent reply other threads:[~2017-05-22 12:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-19 10:19 Jin Yao
2017-05-19 9:29 ` Peter Zijlstra
2017-05-19 9:42 ` Will Deacon
2017-05-19 12:06 ` Jin, Yao
2017-05-19 12:10 ` Peter Zijlstra
2017-05-19 12:24 ` Jin, Yao
2017-05-19 12:36 ` Peter Zijlstra
2017-05-19 13:33 ` Jin, Yao
2017-05-22 2:12 ` Jin, Yao
2017-05-22 8:45 ` Mark Rutland
2017-05-22 9:26 ` Peter Zijlstra
2017-05-22 12:30 ` Jin, Yao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94a086e2-af12-49e9-f9c7-5b4b1b83ddfb@linux.intel.com \
--to=yao.jin@linux.intel.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=will.deacon@arm.com \
--cc=yao.jin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®